Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 363a286efc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - If the report has one named compiler, use its exact `name` for the entire analysis. | ||
| - If the report has multiple compilers, use the compiler explicitly named by the user. When the request identifies a target such as client, server, or worker but does not match an exact compiler name, map it only when the discovery result makes the match unambiguous; otherwise ask the user to choose from the returned names. | ||
| - If a legacy report returns one compiler with `name: null`, omit `--compiler`. | ||
| - Never combine or compare compiler results unless the user explicitly requests cross-compiler analysis. Keep the same selected compiler across the Default Evidence Set and all follow-up queries. |
There was a problem hiding this comment.
When the user explicitly requests a cross-compiler comparison, the first sentence permits combining results, but the next sentence requires keeping one selected compiler across every evidence and follow-up query. Following that instruction means the agent never fetches evidence for the second compiler and cannot perform the requested comparison. Specify that comparison requests run separate, consistent evidence passes for each selected compiler before comparing the results.
Useful? React with 👍 / 👎.
1 participant
Summary
Update the Rsdoctor analysis workflow to discover compilers before fetching evidence and keep one selected compiler across the full analysis. Multi-compiler reports now follow the user's requested target, ambiguous targets require a choice, legacy reports omit
--compiler, and unavailable compiler data stops analysis before partial results are produced.Document
compilers list,compilers_list,--compiler, and recovery for compiler selection errors in the command reference.Related: web-infra-dev/rsdoctor#1885, web-infra-dev/rsdoctor#2003
Validation
pnpm run checkquick_validate.py skills/rsdoctor-analysis