Skip to content

chore(ci): skip Playwright browser installation - #82

Closed
chenjiahan wants to merge 1 commit into
mainfrom
chenjiahan/chore-ci-use-system-chrome
Closed

chenjiahan wants to merge 1 commit into
mainfrom
chenjiahan/chore-ci-use-system-chrome

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Sep 20, 2026

Copy link
Copy Markdown
Member

Use system Chrome for tests and remove the Playwright browser installation step. Local tests now require Chrome to be installed.

Measured over 8 runs per commit (7f091be85137ff). All 32 jobs passed. Times are medians, excluding queue time.

Metric Before After Change
Windows job 58s 45.5s −12.5s (−21.6%)
Ubuntu job 25s 24s −1s (−4%)
Windows Run Test 3s 9s +6s
Ubuntu Run Test 2s 7.5s +5.5s

Removing installation saves 18s on Windows and 9s on Ubuntu, but Chrome startup offsets part of that saving. Diagnostic runs measured a 5–6s first launch on Windows; Ubuntu startup was variable.

Example runs: before, after, startup diagnosis.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-20T08:43:54.246593Z 85137ff PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chenjiahan commented Sep 20, 2026

Copy link
Copy Markdown
Member Author

Closing: Windows CI saves 12.5s (21.6%), but Ubuntu is roughly unchanged. Chrome's cold startup offsets part of the installation savings.

For a reusable template, this benefit does not justify requiring Chrome locally and allowing browser versions to differ across environments. Keeping Playwright's version-matched browser is more reproducible.

A possible follow-up is pnpm exec playwright install chromium --only-shell to reduce downloads while keeping the default browser. This has not been benchmarked.

@chenjiahan chenjiahan closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant