chore(ci): skip Playwright browser installation - #82
chenjiahan wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Closing: Windows CI saves 12.5s (21.6%), but Ubuntu is roughly unchanged. Chrome's cold startup offsets part of the installation savings. For a reusable template, this benefit does not justify requiring Chrome locally and allowing browser versions to differ across environments. Keeping Playwright's version-matched browser is more reproducible. A possible follow-up is |
Use system Chrome for tests and remove the Playwright browser installation step. Local tests now require Chrome to be installed.
Measured over 8 runs per commit (
7f091be→85137ff). All 32 jobs passed. Times are medians, excluding queue time.Run TestRun TestRemoving installation saves 18s on Windows and 9s on Ubuntu, but Chrome startup offsets part of that saving. Diagnostic runs measured a 5–6s first launch on Windows; Ubuntu startup was variable.
Example runs: before, after, startup diagnosis.