Skip to content

feat(rspress): add rspress-plugins ecosystem suite - #97

Merged
SoonIter merged 1 commit into
mainfrom
codex/add-rspress-plugins-suite
Sep 21, 2026
Merged

SoonIter merged 1 commit into
mainfrom
codex/add-rspress-plugins-suite

Conversation

@SoonIter

@SoonIter SoonIter commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Summary

Add rspress-plugins to Rspress ecosystem CI to catch compatibility issues in community plugins. The suite builds packages and docs, then runs unit tests and Chromium E2E tests against the Rspress build under test. It is included in the selectors and full matrices of the from-pr, from-commit, and selected workflows.

Workflow changes take effect on the next dispatch after merge; no SHA pin update is needed.

Validation

Local validation on macOS:

  • pnpm check: passed.
  • pnpm exec tsx ecosystem-ci.ts run-suites --stack rspress --suite-commit 5a8ce7004b7b247b25e6ee259b2cdfb28f3a27af rspress-plugins: package and docs builds, all 13 unit tests, and all 29 Chromium E2E tests passed against the Rspress build at fd825b9.

The two homepage-path E2E failures found during initial validation were fixed in rspress-plugins #38, now merged. The suite was re-run from a fresh downstream checkout without skipping tests.

Copilot AI lite review requested due to automatic review settings September 21, 2026 03:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-21T04:01:08.844904Z 55c9972 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Resolve the two homepage-path E2E failures before enabling the suite in full matrices.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Adds an Rspress plugins ecosystem suite covering builds, documentation, unit tests, and Chromium E2E tests.

Changes:

  • Adds the rspress-plugins integration suite and README usage.
  • Registers the suite in all three Rspress workflow selectors and matrices.
  • Validation reports two E2E failures against Rspress main.
File Description
tests/​rspress/​rspress-plugins.ts Defines plugin builds and validation tests.
README.md Documents running the new suite.
.github/​workflows/​rspress-ecosystem-ci-selected.yml Adds selected-suite support.
.github/​workflows/​rspress-ecosystem-ci-from-pr.yml Adds PR matrix support.
.github/​workflows/​rspress-ecosystem-ci-from-commit.yml Adds commit matrix support.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/rspress/rspress-plugins.ts
@SoonIter
SoonIter merged commit bec3b19 into main Sep 21, 2026
38 of 40 checks passed
@SoonIter
SoonIter deleted the codex/add-rspress-plugins-suite branch September 21, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants