Repository navigation
fix(vscode): detect rslint configs above the workspace folder - #89
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 590b45e714
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 588db7ceda
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4eee01462
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5e1c04597
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afacb3c719
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Opening
repo/packages/appwhile the onlyrslint.config.*sits atrepo/produced no Rslint diagnostics. The rslint CLI, its Go server and the retiredrstack.rslintextension all lint that folder with the root config, so native lint detection now looks above the workspace folder too.detectFolder(folder) in-folder rslint.config.* -> native root rstack.config.* -> bridged + nearest rslint.config.* above -> native (only if @rslint/core resolves from the folder) otherwise -> not detectednode_modulesdirectories, like Go'sfindCandidateUp. It never displaces an in-folder config or a bridged folder.rslint.config.*and sendsrslint/configRefresh. These watchers are installed before the server boots, because Go registers its own ancestor watchers only after initialization: macOS CI lost an edit made right after startup.rs fmtandrs lintread only their cwd.RSLINT_CONFIG_GLOBand the watch globs now derive from a singleRSLINT_CONFIG_NAMES.Evidence: the new E2E suite
suite-ancestoropenspackages/appwith the config two levels up. It checks that theno-debuggerdiagnostic appears and follows edits to the root config. It also checks that deleting the root config unregisters the lint stack and recreating it brings the stack back. With the root rule set tooff, the suite fails with "Timed out … waiting for rslint diagnostics".Related Links
Checklist