Cleanup unused accessor methods inf REXML::Functions - #368
Open
tompng wants to merge 1 commit into
Open
Conversation
Removes unused Functions.variables. It was write only, never read. Removes Functions.namespace_context. It was only used from QuickPath.
There was a problem hiding this comment.
Pull request overview
This PR cleans up dead state/accessors in REXML::FunctionsClass and removes now-unnecessary plumbing from the XPath parsers, following the earlier removal of QuickPath (#362).
Changes:
- Removes the unused
FunctionsClass#variablesand#namespace_contextaccessors and their internal state. - Stops propagating namespaces/variables into
FunctionsClassfrom bothREXML::XPathParserandREXML::Parsers::XPathParser. - Tightens the singleton thread-safety note to reflect the remaining shared state.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/rexml/xpath_parser.rb | Stops writing namespaces/variables into @functions; keeps variables coercion local to the parser. |
| lib/rexml/parsers/xpathparser.rb | Removes the (now-unused) namespace propagation into Functions. |
| lib/rexml/functions.rb | Removes unused accessor methods/state and updates the singleton thread-safety comment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unused
Functions.variables. It was write only, never read.Removes
Functions.namespace_context. It was only used from QuickPath, and QuickPath has been removed in #362