Repository navigation
Conversation
… input
After Zlib::Inflate#add_dictionary has supplied the dictionary, zstream_run_try sets it and calls inflate() again at once. If the dictionary id was the last byte fed so far, that call has no input and returns Z_BUF_ERROR, which was raised although the dictionary was applied and the stream is fine.
```ruby
d = Zlib::Deflate.new
d.set_dictionary("hello world")
data = d.deflate("hello", Zlib::FINISH)
z = Zlib::Inflate.new
z.add_dictionary("hello world")
data.each_byte { |b| z.inflate(b.chr) }
# expected: no error
# actual: Zlib::BufError at the byte that completes the dictionary id
```
Only re-enter inflate() when input remains.
Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
segiddins
force-pushed
the
segiddins/inflate-add-dictionary-buferror
branch
from
October 26, 2026 18:01
34c573a to
44dc344
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After Zlib::Inflate#add_dictionary has supplied the dictionary, zstream_run_try sets it and calls inflate() again at once. If the dictionary id was the last byte fed so far, that call has no input and returns Z_BUF_ERROR, which was raised although the dictionary was applied and the stream is fine.
Only re-enter inflate() when input remains.
🤖 Generated with Claude Code