Repository navigation
Conversation
…onverting
With both external_encoding and internal_encoding given, enc holds the internal encoding and enc2 the external one, as rb_io_extract_encoding_option returns them, but #external_encoding returned enc.
```ruby
io = StringIO.new(Zlib.gzip("abc"))
Zlib::GzipReader.new(io, external_encoding: "ISO-8859-1", internal_encoding: "UTF-8").external_encoding
# expected: #<Encoding:ISO-8859-1>
# actual: #<Encoding:UTF-8>
```
Fixes ruby#81
Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
segiddins
force-pushed
the
segiddins/gzreader-external-encoding
branch
from
October 26, 2026 19:43
6daebda to
5ed4521
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With both
external_encodingandinternal_encodinggiven,encholds the internal encoding andenc2the external one, asrb_io_extract_encoding_optionreturns them, but#external_encodingreturnedenc.Fixes #81