Repository navigation
Conversation
…eader#gets
The separator was searched bytewise with memchr and memcmp, without checking that a match starts on a character boundary. In Shift_JIS the second byte of a character can be an ASCII byte such as "@", "a" or "|", so gets with such a separator cut the character in half. IO#gets only accepts a match on a boundary.
```ruby
gz = Zlib.gzip("\x81\x40?\x81\x40@".b)
r = Zlib::GzipReader.new(StringIO.new(gz), external_encoding: "Shift_JIS")
r.gets("@")
# expected: "\x{8140}?\x{8140}@"
# actual: "\x{8140}"
```
Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
segiddins
force-pushed
the
segiddins/gzreader-gets-separator-char-boundary
branch
from
October 26, 2026 19:43
e4f661e to
92a8701
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The separator was searched bytewise with
memchrandmemcmp, without checking that a match starts on a character boundary. In Shift_JIS the second byte of a character can be an ASCII byte such as "@", "a" or "|", so gets with such a separator cut the character in half.IO#getsonly accepts a match on a boundary.