#164 prescription module - #179
Merged
Merged
Conversation
dpowers1
approved these changes
Aug 29, 2026
dpowers1
left a comment
dpowers1
left a comment
Collaborator
There was a problem hiding this comment.
No blockers, just nits and questions
| @@ -0,0 +1,2 @@ | |||
| module MedicationFormsHelper | |||
|
|
||
| # What has happened since it started, or nil when there is nothing to say. | ||
| def prescription_stopped(prescription) | ||
| stopped = prescription_date(prescription.stop_date) |
Collaborator
There was a problem hiding this comment.
From Claude "summary": "prescription_stopped returns nil for an inactive prescription with no stop_date, leaving a blank sub-note alongside a 'Stopped' badge — indistinguishable from a data gap.",
I was wondering if this could be a problem since stop_date is optional?
| t.string :time_of_day | ||
| t.string :prescribing_doctor | ||
| t.text :purpose | ||
| t.boolean :active |
Collaborator
There was a problem hiding this comment.
Should we default this to true?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Modifies medicine and adds other models to build out full prescription module.
Issue
Closes #164