Group administrative sections behind an Admin menu - #184
Merged
Conversation
The header listed People, Prescriptions, Medications, Medication types and Medication forms as five equal links. The last three are reference data - nobody using the app day to day adds a medication or invents a dosage form - so giving them equal billing with the work the app exists for was misleading. They now sit behind one Admin link leading to /admin, which lists them, and a sub-nav band follows you into each one so they read as part of an area rather than as top-level sections. The resources keep their own top-level paths and controllers; this is grouping in the navigation, not an Admin:: namespace. ApplicationHelper#admin_sections is the single list of what counts as admin, so the header link, the sub-nav and the landing page cannot disagree. When these pages stop being open to everyone, AdminController carries a note on where the gate goes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T1LkcbAaEZigyffSKycUNy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header listed People, Prescriptions, Medications, Medication types and Medication forms as five equal links. The last three are reference data - nobody using the app day to day adds a medication or invents a dosage form - so giving them equal billing with the work the app exists for was misleading.
They now sit behind one Admin link leading to /admin, which lists them, and a sub-nav band follows you into each one so they read as part of an area rather than as top-level sections.
The resources keep their own top-level paths and controllers; this is grouping in the navigation, not an Admin:: namespace. ApplicationHelper#admin_sections is the single list of what counts as admin, so the header link, the sub-nav and the landing page cannot disagree. When these pages stop being open to everyone, AdminController carries a note on where the gate goes.
Issue
Closes #181