Add system tests and video - #137
Merged
Merged
Conversation
johnpaulashenfelter
marked this pull request as ready for review
August 29, 2026 18:18
johnpaulashenfelter
added
the
rubyforgood
johnpaulashenfelter
force-pushed
the
jp/add-system-test-and-video
branch
from
August 29, 2026 18:33
7d08482 to
6ded4b0
Compare
jonny5
approved these changes
Aug 29, 2026
jonny5
left a comment
jonny5
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, haven't seen that video logic before – cool. Only potential concern would be how in flux the designs are and if this is needing to change with regularity
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a system test for the main user journey
Add tools to generate movies of the system tests
journey.mp4