Conversation
voetberg
force-pushed
the
contrib-update
branch
from
September 25, 2026 13:55
4cdf2ff to
c3e5cbf
Compare
rdimaio
reviewed
Sep 25, 2026
Comment on lines
+117
to
+118
| For example, if a refactor is used to improve the quality of a feature, a commit with the `refactor` | ||
| isolated should included alongside the `feat` commit. |
Contributor
There was a problem hiding this comment.
Wording here seems a bit off to me, maybe this improves it
Suggested change
| For example, if a refactor is used to improve the quality of a feature, a commit with the `refactor` | |
| isolated should included alongside the `feat` commit. | |
| For example, if a refactor is used to improve the quality of a feature, a commit with the `refactor` | |
| isolated should be included alongside the `feat` commit. |
but also '...a commit with the refactorisolated' could be improved imo
Contributor
Author
There was a problem hiding this comment.
Yeah I workshopped this a few different ways and I couldn't settle on anything better. Back to the drawing board!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are things I'm always pointing out to new contributors, maybe it's not clear in the contributing guide.