riscv: use CSR immediate instructions for set_csr!/clear_csr! field masks - #417
Merged
romancardenas merged 1 commit intoSep 19, 2026
Merged
Conversation
Contributor
|
Hi, @XuanTongYao ! Please make the required changes so CI passes. Then, I will review your changes. |
Contributor
Author
|
Hi @romancardenas ! I tried making it compatible with versions prior to 1.82.0 |
Contributor
|
Looks good to me, thank you! Could you add a brief note on |
XuanTongYao
force-pushed
the
feat/set-clear-csr-uimm
branch
from
September 18, 2026 06:09
efd2053 to
9819eb6
Compare
Contributor
Author
|
Got it! I’ve added the changelog and rebased onto main. |
Contributor
|
@XuanTongYao thanks! Sorry for being picky, but could you squash your three commits into a single one, so the commit history is cleaner? |
XuanTongYao
force-pushed
the
feat/set-clear-csr-uimm
branch
from
September 18, 2026 07:17
9819eb6 to
7b10e7f
Compare
Contributor
Author
|
@romancardenas thanks. A QEMU test was canceled for unknown reasons. Could you please restart it? |
Merged
via the queue into
rust-embedded:master
with commit Sep 19, 2026
b3a70b7
184 of 185 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #393