crate: change padding fields to use Padding - #5435
Open
dybucc wants to merge 2 commits into
Open
Conversation
tgross35
requested changes
Aug 25, 2026
Member
There was a problem hiding this comment.
Could you split this into separate commits?
- Changes to fields that are already private
- Changes to fields that are deprecated
- Changes to fields that are public (preferably a separate PR for labels)
That way I can backport the first two but hold off on the last one. I know our policy technically does allow us to change them, but some of these are pretty popular structs so I'd like to be a bit cautious anyway.
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
Replace the types of private padding fields with our custom `Padding` type. This has been in use for some time, but there are still remnants left from before the `Padding` type was a thing.
dybucc
force-pushed
the
add-padding-remaining
branch
from
August 28, 2026 14:32
7b8c9ca to
7ef72d4
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Replace types of padding fields that were deprecated for the `Padding` type. The deprecation warnings have been there for more than 6 years, so it's fine to act on them now. Make afore-mentioned padding fields private.
dybucc
force-pushed
the
add-padding-remaining
branch
from
August 28, 2026 16:39
7ef72d4 to
7d73557
Compare
4 tasks
rustbot
added
the
stable-nominated
Contributor
Author
|
@rustbot ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attempts to change whichever padding fields didn’t already use our custom
Paddingtype. Closes #1453.Originally, this description didn't contain the command used for searching the files. Other than the search results found by the following shell command, each of those files was manually inspected.
A split PR with changes to the public field lives now at #5444.
Checklist
libc-test/semverhave been updated*LASTor*MAXhave the standard doc commentcargo test -p libc-test --target mytarget); especially relevant for platforms that may not be checked in CI@rustbot label +stable-nominated