linux_like(android,linux): remove af_alg_iv unsound implementations in extra_traits feature - #5443
Open
dybucc wants to merge 1 commit into
Open
linux_like(android,linux): remove af_alg_iv unsound implementations in extra_traits feature#5443dybucc wants to merge 1 commit into
af_alg_iv unsound implementations in extra_traits feature#5443dybucc wants to merge 1 commit into
Conversation
Remove `extra_traits` implementations for `af_alg_iv` in stable to solve the soundness issue reported at rust-lang#1501. This was already deprecated on `main` in rust-lang#1703, and removed in rust-lang/libc@0c9b044. This patch ports those changes to the next stable release as it's been quite some time since then.
Collaborator
|
Some changes occurred in an Android module cc @maurer |
rustbot
added
O-android
O-linux
O-linux-like
O-unix
S-waiting-on-review
stable-nominated
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1501. See that issue for details on the
unsoundness report. That was fixed a while ago on
mainbut the patchwould have broken stable, so a deprecation warning was applied instead.
Follows a brief discussion at
#1501 (comment).
Note the automatically-derived implementations for
DebugandClonefor this type seem odd now. The last member is a FAM upstream, so I
think
Debugcan just live with that, butClonewouldn't feel rightto provide without some word of warning to users about the "extended"
length beyond the trailing
structmember not being copied over tothe new instance of the type. I guess downstream users can then use a
newtype to implement
Cloneas they see fit; The fields onaf_alg_ivare public, after all.
Checklist
libc-test/semverhave been updated*LASTor*MAXhave thestandard doc comment
cargo test -p libc-test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated