Constant evaluation regression in beta 1.26

[emilyalbini]

There were some constant evaluation failures in the beta crater run.

• ostn02_phf regressed from stable to beta (1.25 build log - 1.26 build log) cc @urschrei
• out123-sys 0.2.1 regressed from stable to beta (1.25 build log - 1.26 build log) cc @IvanUkhov

The first crate is actually deprecated/abandoned, and the second regression only appears in an old version (the latest is version 0.5.0). cc @oli-obk

[oli-obk]

fixing the ostn02_phf case is simple, I thought I already did that, but apparently not. I'll remove the complexity check and make it a lint as discussed in rust-lang/rfcs#2344 (comment)

[emilyalbini]

The ostn02_phf fix is being backported to beta in #50027

[urschrei]

Is that fix also in nightly? ostn02_phf is indeed deprecated, but its replacement (ostn15_phf) has an open issue which (as I just found out) is dependent on the fix – it currently only builds on stable macOS / Linux

[emilyalbini]

Is that fix also being backported to nightly?

@urschrei that fix is already available in the nightly (master) branch, and the PR I linked backports it to beta. The only "problem" is, since Sunday no new nightlies were released because rls is broken. Once rls will be fixed new nightlies (with the regression fixed) will be released.

[urschrei]

@pietroalbini Thanks!

[emilyalbini]

The ostn02_phf fix is backported to beta. What about out123-sys 0.2.1 @oli-obk?

[oli-obk]

nightly PR in progress: #50072

still needs a beta-accepted stamp