rls no longer builds after rust-lang/rust#98975 #99234

Activity

1. rust-highfive

   added

   A-rls

   C-bugCategory: This is a bug.Category: This is a bug.

   on Jul 14, 2022
2. rust-highfive

   assigned

   Xanewok

   on Jul 14, 2022
3. jyn514 commented on Jul 14, 2022

   

   jyn514

   on Jul 14, 2022

   Member

   More actions

   Yes, I think I'll have time to fix this today.
4. jyn514 commented on Jul 14, 2022

   

   jyn514

   on Jul 14, 2022

   Member

   More actions

   I think there are other changes that need to happen first. I tried to compile with tonight's nightly and got lots of errors from rustfmt:

   error[E0532]: expected unit struct, unit variant or constant, found tuple variant `ast::Extern::Implicit`
      --> /home/jnelson/.local/lib/cargo/git/checkouts/rustfmt-c4b65366788d3254/5fa2727/src/utils.rs:141:9
       |
   141 |         ast::Extern::Implicit => "C".to_owned(),
       |         ^^^^^^^^^^^^^^^^^^^^^
   

   @Xanewok do you know what could be going wrong? do I need to update rustfmt or something like that?
5. Xanewok commented on Jul 14, 2022

   

   Xanewok

   on Jul 14, 2022

   Contributor

   More actions

   I pushed the latest update at rust-lang/rls@ac4648b. @jyn514 is the failure above from the x.py test build here or in the RLS repo?

   Rustfmt should be vendored here and should work as expected IIUC.
6. jyn514 commented on Jul 14, 2022

   

   jyn514

   on Jul 14, 2022

   Member

   More actions

   @Xanewok that's in the RLS repo.
7. Dylan-DPC

   added a commit that references this issue on Jul 15, 2022

   Rollup merge of rust-lang#99246 - Xanewok:update-rls, r=jyn514

   ...

   This issue will close once commit 8e3dd62 is merged into the 'master' branch.

   8e3dd62
8. bors

   closed this as completedin 8e3dd62on Jul 15, 2022