Doc: Extend for tuples to be stabilized in 1.85.0 - #134022
Conversation
|
It was supposed to be |
|
Oh, ooops. Now it makes more sense why I found only a single occurence of RUSTC_CURRENT_VERSION after the merge. Should I leave this PR as is or should I change it to CURRENT_RUSTC_VERSION? |
|
Since #132187 is destined for 1.85 which is the current nightly, you can just change it to |
238775d to
bfd2bc3
Compare
|
Hope it's OK now :) |
| #[doc = "This trait is implemented for tuples up to twelve items long. The `impl`s for\ | ||
| 1- and 3- through 12-ary tuples were stabilized after 2-tuples, in\ |
There was a problem hiding this comment.
All whitespace after \ gets stripped so these need a space before \, otherwise it gets smooshed together ("impls for1- and 3-" and "2-tuples, inCURRENT_RUSTC_VERSION.")
commented
Dec 14, 2024
Significantly, thanks :) Two more nits above then lgtm. |
commented
Dec 14, 2024
|
Also - I appreciate the credit (certainly not needed, minor suggestions are usually without attribution requirements) but small request, could you drop the GH username from the commit message? We found out the hard way that github is pretty overzealous with notifications otherwise and will ping every time somebody applies this commit to a fork 😆 |
bfd2bc3 to
cdb72a2
Compare
I mixed it up with RUSTC_CURRENT_VERSION unfortunately. Also improve the formatting of the macro invocation slightly.
cdb72a2 to
7717df2
Compare
commented
Dec 14, 2024
|
Oh ouch, that's annoying about the notifications. I did not mean to spam you of course, dropped the username. And thanks for the fast review! |
commented
Dec 14, 2024
|
@bors r+ rollup |
I assumed the RUSTC_CURRENT_VERSION would be replaced automatically, but it doesn't look like it on the nightly docs page. Sorry!