When error from local macro, include macro def span by estebank · Pull Request #161051 · rust-lang/rust

estebank · 2026-08-13T14:24:35Z

mention -Zmacro-backtrace only for non-local macros
include span for local macro encompassing error

rustbot · 2026-08-13T14:25:03Z

rustc_errors::emitter was changed

rustbot · 2026-08-13T14:25:06Z

rustbot has assigned @adwinwhite.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 18 candidates

rustbot · 2026-09-19T21:24:20Z

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

rustbot · 2026-09-19T21:24:22Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

- mention `-Zmacro-backtrace` only for non-local macros - include span for local macro encompassing error

adwinwhite · 2026-09-21T02:25:28Z

@bors r+

rust-bors · 2026-09-21T02:25:32Z

📌 Commit f1e9e5e has been approved by adwinwhite

It is now in the queue for this repository.

…hite When error from local macro, include macro def span - mention `-Zmacro-backtrace` only for non-local macros - include span for local macro encompassing error

Rollup of 15 pull requests Successful merges: - #161051 (When error from local macro, include macro def span) - #162750 (add case mapping fast paths for Latin-1) - #162831 (Do not continue past `rustc_resolve` when encountering duplicated items) - #162835 (rustdoc: account for nested parens and split text events in bare urls lint) - #163044 (Report runtime range endpoints for runtime values) - #163062 (Use x30 register name with LLVM 23+) - #158102 (When compiling without a specified `--edition`, emit a note) - #162984 (Windows: don't error if `access_mode` is set on `OpenOptions`) - #163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`) - #163019 (Prepare for the introduction of forced keywords (`k#`)) - #163020 (Dir: fix fallback impl for remove_dir) - #163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`) - #163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64) - #163079 (enable `f128` from `u64`/`i64` test) - #163082 (Remove `TypeChecker::root_cx`)

…hite When error from local macro, include macro def span - mention `-Zmacro-backtrace` only for non-local macros - include span for local macro encompassing error

…uwer Rollup of 18 pull requests Successful merges: - #161051 (When error from local macro, include macro def span) - #161629 (Streamline `StateDiffCollector`) - #162750 (add case mapping fast paths for Latin-1) - #162831 (Do not continue past `rustc_resolve` when encountering duplicated items) - #162835 (rustdoc: account for nested parens and split text events in bare urls lint) - #162952 (Depend on lockfiles to prevent GC of the current session) - #163044 (Report runtime range endpoints for runtime values) - #163062 (Use x30 register name with LLVM 23+) - #158102 (When compiling without a specified `--edition`, emit a note) - #162939 (Declare multi-kind constants for MacroKinds) - #162984 (Windows: don't error if `access_mode` is set on `OpenOptions`) - #163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`) - #163019 (Prepare for the introduction of forced keywords (`k#`)) - #163020 (Dir: fix fallback impl for remove_dir) - #163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`) - #163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64) - #163079 (enable `f128` from `u64`/`i64` test) - #163082 (Remove `TypeChecker::root_cx`)

rust-bors · 2026-09-21T08:15:42Z

⌛ Testing commit f1e9e5e with merge 9dc0b07...

Workflow: https://github.com/rust-lang/rust/actions/runs/35576979212

When error from local macro, include macro def span - mention `-Zmacro-backtrace` only for non-local macros - include span for local macro encompassing error

JonathanBrouwer · 2026-09-21T08:16:46Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-09-21T08:16:51Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/35576979212

The next pull request likely to be tested is #163095.

…uwer Rollup of 19 pull requests Successful merges: - #161051 (When error from local macro, include macro def span) - #161629 (Streamline `StateDiffCollector`) - #162750 (add case mapping fast paths for Latin-1) - #162831 (Do not continue past `rustc_resolve` when encountering duplicated items) - #162835 (rustdoc: account for nested parens and split text events in bare urls lint) - #162952 (Depend on lockfiles to prevent GC of the current session) - #163044 (Report runtime range endpoints for runtime values) - #163062 (Use x30 register name with LLVM 23+) - #163091 (miri subtree update) - #162939 (Declare multi-kind constants for MacroKinds) - #162984 (Windows: don't error if `access_mode` is set on `OpenOptions`) - #163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`) - #163019 (Prepare for the introduction of forced keywords (`k#`)) - #163020 (Dir: fix fallback impl for remove_dir) - #163041 (Be more explicit on suggestion type without changing how they are rendered) - #163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`) - #163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64) - #163079 (enable `f128` from `u64`/`i64` test) - #163082 (Remove `TypeChecker::root_cx`)

Rollup merge of #161051 - estebank:macro_backtrace, r=adwinwhite When error from local macro, include macro def span - mention `-Zmacro-backtrace` only for non-local macros - include span for local macro encompassing error

rust-timer · 2026-09-21T12:38:43Z

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (57e3e66): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.5%]	8
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	0.3%	[0.2%, 0.5%]	8

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: missing data
Artifact size: 408.93 MiB -> 408.98 MiB (0.01%)

…uwer Rollup of 19 pull requests Successful merges: - rust-lang/rust#161051 (When error from local macro, include macro def span) - rust-lang/rust#161629 (Streamline `StateDiffCollector`) - rust-lang/rust#162750 (add case mapping fast paths for Latin-1) - rust-lang/rust#162831 (Do not continue past `rustc_resolve` when encountering duplicated items) - rust-lang/rust#162835 (rustdoc: account for nested parens and split text events in bare urls lint) - rust-lang/rust#162952 (Depend on lockfiles to prevent GC of the current session) - rust-lang/rust#163044 (Report runtime range endpoints for runtime values) - rust-lang/rust#163062 (Use x30 register name with LLVM 23+) - rust-lang/rust#163091 (miri subtree update) - rust-lang/rust#162939 (Declare multi-kind constants for MacroKinds) - rust-lang/rust#162984 (Windows: don't error if `access_mode` is set on `OpenOptions`) - rust-lang/rust#163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`) - rust-lang/rust#163019 (Prepare for the introduction of forced keywords (`k#`)) - rust-lang/rust#163020 (Dir: fix fallback impl for remove_dir) - rust-lang/rust#163041 (Be more explicit on suggestion type without changing how they are rendered) - rust-lang/rust#163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`) - rust-lang/rust#163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64) - rust-lang/rust#163079 (enable `f128` from `u64`/`i64` test) - rust-lang/rust#163082 (Remove `TypeChecker::root_cx`)

Mark-Simulacrum · 2026-09-24T22:40:00Z

This looks like it's a diagnostic change which is sort of a correctness fix;
probably an OK regression to accept. It might be limited to code that emits
diagnostics (so probably related to old version of syn we have here).

Marking as triaged.

estebank · 2026-09-25T02:54:56Z

@Mark-Simulacrum to be clear, it would be ok to revert. It also makes sense that syn would be most affected (but should only happen once errors are actually emitted, not in the happy path...)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 13, 2026

rustbot assigned adwinwhite Aug 13, 2026

This comment has been minimized.

Sign in to view

estebank force-pushed the macro_backtrace branch from 1f00b5c to 8abeab8 Compare September 19, 2026 21:24

rustbot added the T-clippy Relevant to the Clippy team. label Sep 19, 2026

estebank force-pushed the macro_backtrace branch from 8abeab8 to 224b072 Compare September 19, 2026 21:43

rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Sep 19, 2026

estebank force-pushed the macro_backtrace branch 3 times, most recently from 05444dc to 6df7b96 Compare September 19, 2026 21:46

This comment has been minimized.

Sign in to view

estebank force-pushed the macro_backtrace branch from 6df7b96 to 54aa034 Compare September 20, 2026 00:12

This comment has been minimized.

Sign in to view

When error from local macro, include macro def span

f1e9e5e

- mention `-Zmacro-backtrace` only for non-local macros - include span for local macro encompassing error

estebank force-pushed the macro_backtrace branch from 54aa034 to f1e9e5e Compare September 20, 2026 04:11

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2026

Zalathar mentioned this pull request Sep 21, 2026

Rollup of 15 pull requests #163086

Closed

JonathanBrouwer mentioned this pull request Sep 21, 2026

Rollup of 18 pull requests #163089

Closed

JonathanBrouwer mentioned this pull request Sep 21, 2026

Rollup of 19 pull requests #163095

Merged

rust-bors Bot merged commit 848ef40 into rust-lang:main Sep 21, 2026
13 of 14 checks passed

rustbot added this to the 1.100.0 milestone Sep 21, 2026

rustbot added the perf-regression Performance regression. label Sep 21, 2026

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Sep 24, 2026

Uh oh!

Conversation

estebank commented Aug 13, 2026

Uh oh!

rustbot commented Aug 13, 2026

Uh oh!

rustbot commented Aug 13, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Sep 19, 2026

Uh oh!

rustbot commented Sep 19, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

adwinwhite commented Sep 21, 2026

Uh oh!

rust-bors Bot commented Sep 21, 2026

Uh oh!

rust-bors Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Sep 21, 2026

Uh oh!

rust-bors Bot commented Sep 21, 2026

Uh oh!

Uh oh!

rust-timer commented Sep 21, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Mark-Simulacrum commented Sep 24, 2026

Uh oh!

estebank commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rust-bors Bot commented Sep 21, 2026 •

edited

Loading

estebank commented Sep 25, 2026 •

edited

Loading