Allow Unpin impls for local extern type - #161692
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 27, 2026
Allow Unpin impls for local extern type Fixes rust-lang#155053 `visit_implementation_of_unpin` helper only handles `ty::Adt` and does delay the bug for everything else. The orphan check is what allows a local foreign type i.e. `ty::Foreign` and that's why we can each that arm and ICE. Discloure: Only the test comments were genarated using an LLM.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 27, 2026
Allow Unpin impls for local extern type Fixes rust-lang#155053 `visit_implementation_of_unpin` helper only handles `ty::Adt` and does delay the bug for everything else. The orphan check is what allows a local foreign type i.e. `ty::Foreign` and that's why we can each that arm and ICE. Discloure: Only the test comments were genarated using an LLM.
Member
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #161875 (comment) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#161875), which was unapproved. |
mehdiakiki
force-pushed
the
issue-155053
branch
from
August 27, 2026 20:46
430719a to
b5e7cbf
Compare
Collaborator
|
This PR changes a file inside |
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@rustbot review |
rustbot
added
S-waiting-on-review
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 29, 2026
Rollup merge of #161692 - mehdiakiki:issue-155053, r=chenyukang Allow Unpin impls for local extern type Fixes #155053 `visit_implementation_of_unpin` helper only handles `ty::Adt` and does delay the bug for everything else. The orphan check is what allows a local foreign type i.e. `ty::Foreign` and that's why we can each that arm and ICE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155053
visit_implementation_of_unpinhelper only handlesty::Adtand does delay the bug for everything else. The orphan check is what allows a local foreign type i.e.ty::Foreignand that's why we can each that arm and ICE.