Fix a compile error on the ESP-IDF target - #162049
Merged
rust-bors[bot] merged 1 commit intoAug 31, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
Whoops, sorry about that! |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 31, 2026
…ize, r=joboet Fix a compile error on the ESP-IDF target PR rust-lang#160848 accidentally broke the Tier-3 ESP-IDF target by leaving out one reference to `attr.as_ptr()` which should've been changed to `attr.get()`. This PR does the absolute minimum to restore correct behavior for the ESP-IDF target (and Nuttx). CC @joboet @nia-e
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
Rollup of 5 pull requests Successful merges: - #161556 (document some rustc_dump attributes) - #161353 (Add test for parallel compiler reproducible build) - #161776 (Add a couple polonius tests and move universal region liveness generation) - #162002 (Output `tests/debuginfo` raw JSON data on failure in CI) - #162049 (Fix a compile error on the ESP-IDF target)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 31, 2026
…ize, r=joboet Fix a compile error on the ESP-IDF target PR rust-lang#160848 accidentally broke the Tier-3 ESP-IDF target by leaving out one reference to `attr.as_ptr()` which should've been changed to `attr.get()`. This PR does the absolute minimum to restore correct behavior for the ESP-IDF target (and Nuttx). CC @joboet @nia-e
This was referenced Aug 31, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162058 (Port 1.98.1 release notes into main) - #161556 (document some rustc_dump attributes) - #161776 (Add a couple polonius tests and move universal region liveness generation) - #162002 (Output `tests/debuginfo` raw JSON data on failure in CI) - #162049 (Fix a compile error on the ESP-IDF target) - #162054 (Refine InferCtxtInner docs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162058 (Port 1.98.1 release notes into main) - #161556 (document some rustc_dump attributes) - #161776 (Add a couple polonius tests and move universal region liveness generation) - #162002 (Output `tests/debuginfo` raw JSON data on failure in CI) - #162049 (Fix a compile error on the ESP-IDF target) - #162054 (Refine InferCtxtInner docs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162058 (Port 1.98.1 release notes into main) - #161556 (document some rustc_dump attributes) - #161776 (Add a couple polonius tests and move universal region liveness generation) - #162002 (Output `tests/debuginfo` raw JSON data on failure in CI) - #162049 (Fix a compile error on the ESP-IDF target) - #162054 (Refine InferCtxtInner docs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
Rollup merge of #162049 - ivmarkov:fix-espidf-thread-stack-size, r=joboet Fix a compile error on the ESP-IDF target PR #160848 accidentally broke the Tier-3 ESP-IDF target by leaving out one reference to `attr.as_ptr()` which should've been changed to `attr.get()`. This PR does the absolute minimum to restore correct behavior for the ESP-IDF target (and Nuttx). CC @joboet @nia-e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #160848 accidentally broke the Tier-3 ESP-IDF target by leaving out one reference to
attr.as_ptr()which should've been changed toattr.get().This PR does the absolute minimum to restore correct behavior for the ESP-IDF target (and Nuttx).
CC
@joboet
@nia-e