Skip to content

Add bootstrap command to check all Tier 2+ targets - #162053

Open
Kobzol wants to merge 5 commits into
rust-lang:mainfrom
Kobzol:check-all-targets
Open

Add bootstrap command to check all Tier 2+ targets#162053
Kobzol wants to merge 5 commits into
rust-lang:mainfrom
Kobzol:check-all-targets

Conversation

@Kobzol

@Kobzol Kobzol commented Aug 31, 2026

Copy link
Copy Markdown
Member

Alternative to #162020 (CC @ChrisDenton).

I suspect it will be way to slow when run serially on CI though.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 31, 2026
@rustbot

rustbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 31, 2026
Comment thread src/bootstrap/src/core/build_steps/check.rs Outdated
Comment thread src/bootstrap/src/core/build_steps/synthetic_targets.rs Outdated
Comment thread src/bootstrap/src/core/build_steps/check.rs Outdated
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Kobzol
Kobzol force-pushed the check-all-targets branch from c70b513 to aa1788d Compare August 31, 2026 14:21
@Kobzol

Kobzol commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

Well, it's too slow for PR CI, but fine for an auto job.

@ChrisDenton

Copy link
Copy Markdown
Member

Something we can try sounds great. Usually reviewers will be aware if the PR is touching platform specific code. And it can be run on rollups if/when needed.

}

/// Check the standard library for all Tier 2 and Tier 1 targets.
/// Queries a the stage 1 compiler to find the target tiers.

@DanielEScherzer DanielEScherzer Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Queries a the stage 1 compiler to find the target tiers.
/// Queries the stage 1 compiler to find the target tiers.

View changes since the review

// that issue somewhere else, but we still want to keep `check::Std` at the end so that the
// quicker steps run before this.
check::Std,
check::StdImportantTargets

@DanielEScherzer DanielEScherzer Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to simplify future diffs

Suggested change
check::StdImportantTargets
check::StdImportantTargets,

View changes since the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants