let people change rustc-dev-guide in-tree - #162255
Merged
Merged
Conversation
rustbot
added
A-meta
Collaborator
|
|
Member
|
Did this message get changed at some point 🤔 It really should say "if this PR only touches the dev gudie then..." we definitely want people touching things in-tree |
Member
|
Yes #157169 😔 |
Member
|
Can we just revert that PRs change to the dev guide. I much prefer the older message 😅 |
Member
Author
|
adjusted the wording to match meaning of old message would rather ask people to do so in future prs, instead of have them close their pr and submitting the same changes upstream if that goes too far @BoxyUwU, you may approve this pr as it is |
Member
|
@bors r+ thanks for noticing this |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
|
oh though yeah I don't mind adjusting the old wording to also make it clear that it's fine to land stuff in r-l/r it's just slower |
Member
|
feel free to r- and make those changes if you wish |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 4, 2026
let people change rustc-dev-guide in-tree am happy for people to edit the document in this repo... let's not scare them away, or waste their time [example message](rust-lang#160100 (comment)) that resulted in [reverting a positive change](https://github.com/rust-lang/rust/compare/ff6dcf461b4f15551d54cdc0e92a576e48357cc3..76bb5f07890ba6b455b7b75b73975f749b8e3fc3) r? @BoxyUwU
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#162307), which was closed. |
Member
Author
|
oops, sorry for cancelling the rollup |
Member
Author
|
@bors info |
Contributor
Status of PR
|
Member
Author
|
@bors squash |
This comment has been minimized.
This comment has been minimized.
* let people change rustc-dev-guide in-tree * direct people upstream when appropriate * no need to re-submit current changes * typo * tweak
Contributor
|
🔨 5 commits were squashed into 7b83b5a. |
rust-bors
Bot
force-pushed
the
patch-3
branch
from
September 4, 2026 17:14
5295860 to
7b83b5a
Compare
Member
Author
|
@bors squash message='do not discourage people from changing rustc-dev-guide in-tree' |
Contributor
|
❗ The PR has only one commit. |
Member
|
cool r=me on CI passing |
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 5, 2026
…uwer Rollup of 25 pull requests Successful merges: - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`) - #162179 (type system const items via direct rhs) - #162255 (let people change rustc-dev-guide in-tree) - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`) - #162277 (Introduce `rustc_middle::middel::resolve`) - #162285 (box: fixup map/try_map deallocate calls) - #162286 (string: don't unwind prematurely) - #162289 (alloc: a bunch of safety comments) - #162290 (abby test DSL: AliasTyOutlivesViaEnv) - #162292 (Update `askama` version to `0.16.1`) - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) - #160906 (Suggest usize instead of placeholder type for array length constants) - #160936 (traits: Represent live alias arguments as bitsets) - #161394 (fix `is_homogeneous_aggregate`: use unit size, not total size ) - #161400 (Improve diagnostics for references to closures) - #161656 (Suggest mutable references for FnMut closure arguments) - #161711 (Add more splat fn type tests) - #161786 (Make `tcx.def_id_partial_cmp` public) - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers) - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute) - #162212 (Implement `Rng` for `Box`) - #162246 (Fix incorrect meta span) - #162266 (std: fix typo) - #162291 (Add regression test from 1.98.1) - #162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)
Member
|
@bors rollup=always |
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 5, 2026
…uwer Rollup of 25 pull requests Successful merges: - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`) - #162179 (type system const items via direct rhs) - #162255 (let people change rustc-dev-guide in-tree) - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`) - #162277 (Introduce `rustc_middle::middel::resolve`) - #162285 (box: fixup map/try_map deallocate calls) - #162286 (string: don't unwind prematurely) - #162289 (alloc: a bunch of safety comments) - #162290 (abby test DSL: AliasTyOutlivesViaEnv) - #162292 (Update `askama` version to `0.16.1`) - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) - #160906 (Suggest usize instead of placeholder type for array length constants) - #160936 (traits: Represent live alias arguments as bitsets) - #161394 (fix `is_homogeneous_aggregate`: use unit size, not total size ) - #161400 (Improve diagnostics for references to closures) - #161656 (Suggest mutable references for FnMut closure arguments) - #161711 (Add more splat fn type tests) - #161786 (Make `tcx.def_id_partial_cmp` public) - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers) - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute) - #162212 (Implement `Rng` for `Box`) - #162246 (Fix incorrect meta span) - #162266 (std: fix typo) - #162291 (Add regression test from 1.98.1) - #162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 5, 2026
Rollup merge of #162255 - tshepang:patch-3, r=BoxyUwU let people change rustc-dev-guide in-tree am happy for people to edit the document in this repo... let's not scare them away, or waste their time [example message](#160100 (comment)) that resulted in [reverting a positive change](https://github.com/rust-lang/rust/compare/ff6dcf461b4f15551d54cdc0e92a576e48357cc3..76bb5f07890ba6b455b7b75b73975f749b8e3fc3) r? @BoxyUwU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
am happy for people to edit the document in this repo... let's not scare them away, or waste their time
example message that resulted in reverting a positive change
r? @BoxyUwU