Skip to content

Use attribute parser for checking #[may_dangle] attribute - #162886

Open
obeis wants to merge 3 commits into
rust-lang:mainfrom
obeis:check-may-dangle
Open

obeis wants to merge 3 commits into
rust-lang:mainfrom
obeis:check-may-dangle

Conversation

@obeis

@obeis obeis commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Updates #153101

This PR is stacked on top of #162683 and #162530, review should be on the last commit only. Once those PRs are merged, I will rebase my branch.

r? @JonathanBrouwer

CC @mejrs

@rustbot

rustbot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 17, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member

I'll wait with reviewing this until the two PRs its based on have landed

@rust-bors

rust-bors Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants