check is_indirect_first_projection when replacing in RefProp by saethlin · Pull Request #163778 · rust-lang/rust

saethlin · 2026-10-05T02:09:36Z

This is a fix for #163777.

The test case is generated by an LLM.

rustbot · 2026-10-05T02:09:39Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

rustbot · 2026-10-05T02:09:41Z

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 77 candidates
Random selection from 17 candidates

saethlin · 2026-10-05T02:09:48Z

r? dianqk

dianqk

Nice catch!

View changes since this review

dianqk · 2026-10-06T13:28:28Z

@bors r+ rollup

rust-bors · 2026-10-06T13:28:31Z

📌 Commit 7a1ec8e has been approved by dianqk

It is now in the queue for this repository.

…r=dianqk check is_indirect_first_projection when replacing in RefProp This is a fix for rust-lang#163777. The test case is generated by an LLM.

…uwer Rollup of 17 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163870 (Add if-installed:auto:spellcheck to pre-push script) - #163874 (explicitly check for fresh vars in canonicalize) - #163880 (Don't add pkgs.rustc to PATH in nix dev shell)

…r=dianqk check is_indirect_first_projection when replacing in RefProp This is a fix for rust-lang#163777. The test case is generated by an LLM.

…uwer Rollup of 25 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #162156 (add IBM f128 type) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

…r=dianqk check is_indirect_first_projection when replacing in RefProp This is a fix for rust-lang#163777. The test case is generated by an LLM.

…uwer Rollup of 24 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

…uwer Rollup of 23 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

Rollup merge of #163778 - saethlin:refprop-indirect-places, r=dianqk check is_indirect_first_projection when replacing in RefProp This is a fix for #163777. The test case is generated by an LLM.

rust-timer · 2026-10-08T07:21:23Z

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (feb900b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.3%, -0.2%]	2
Improvements ✅ (secondary)	-0.3%	[-0.5%, -0.1%]	12
All ❌✅ (primary)	-0.2%	[-0.3%, -0.2%]	2

Max RSS (memory usage)

Results (primary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-1.2%, -1.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.2%	[-1.2%, -1.2%]	1

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Artifact size: 408.59 MiB -> 408.65 MiB (0.01%)

JonathanBrouwer · 2026-10-08T16:23:00Z

This is noise, all PRs in the rollup have the same results

…uwer Rollup of 23 pull requests Successful merges: - rust-lang/rust#163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - rust-lang/rust#163806 (even more `tests/crashes` migration for `-Znext-solver`) - rust-lang/rust#163508 (Document the `rustc_on_unimplemented` attribute.) - rust-lang/rust#163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - rust-lang/rust#163863 (use the type name instead of `Self` in constructor paths again) - rust-lang/rust#163864 (Remove CLAUDE.md) - rust-lang/rust#163877 (Add regression test for duplicated rustdoc search results between std and core) - rust-lang/rust#163916 (Shrink `PartialRes` and its alignment) - rust-lang/rust#149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - rust-lang/rust#152557 (Oneshot `is_ready`) - rust-lang/rust#157273 (Stabilize `optimize` attribute) - rust-lang/rust#162000 (peel_transparent_wrappers only works on non-1ZST) - rust-lang/rust#163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - rust-lang/rust#163348 (perf:cache FFI safety results in improper_ctypes lint) - rust-lang/rust#163768 (Move more `rustdoc-html` tests in the right location) - rust-lang/rust#163778 (check is_indirect_first_projection when replacing in RefProp) - rust-lang/rust#163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - rust-lang/rust#163807 (Add `has_reliable_f16b` for Arm) - rust-lang/rust#163809 (Switch TLS implementation for wasi and bump SDK version to 34) - rust-lang/rust#163826 (Update books) - rust-lang/rust#163849 (ci: update to PowerShell 7.6.6) - rust-lang/rust#163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - rust-lang/rust#163870 (Add if-installed:auto:spellcheck to pre-push script)

check is_indirect_first_projection when replacing in RefProp

7a1ec8e

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2026

rustbot assigned chenyukang Oct 5, 2026

saethlin assigned dianqk and unassigned chenyukang Oct 5, 2026

This comment was marked as outdated.

Sign in to view

saethlin linked an issue Oct 6, 2026 that may be closed by this pull request

ReferencePropagation looks through field projections to find reborrow chains, but not when replacing #163777

Closed

dianqk approved these changes Oct 6, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2026

JonathanBrouwer mentioned this pull request Oct 6, 2026

Rollup of 17 pull requests #163884

Closed

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 25 pull requests #163919

Closed

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 24 pull requests #163934

Closed

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 23 pull requests #163957

Merged

rust-bors Bot merged commit 66a3060 into rust-lang:main Oct 8, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 8, 2026

github-actions Bot mentioned this pull request Oct 9, 2026

Toolchain upgrade to nightly-2026-10-09 flux-rs/flux#1811

Draft

Navigation Menu

Repository navigation

check is_indirect_first_projection when replacing in RefProp - #163778

check is_indirect_first_projection when replacing in RefProp#163778
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
saethlin:refprop-indirect-places

saethlin commented Oct 5, 2026

Uh oh!

rustbot commented Oct 5, 2026

Uh oh!

rustbot commented Oct 5, 2026

Uh oh!

saethlin commented Oct 5, 2026

Uh oh!

This comment was marked as outdated.

dianqk left a comment •

edited by rustbot

Loading

Uh oh!

dianqk commented Oct 6, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

Uh oh!

rust-timer commented Oct 8, 2026

Uh oh!

JonathanBrouwer commented Oct 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

saethlin commented Oct 5, 2026

Uh oh!

rustbot commented Oct 5, 2026

Uh oh!

rustbot commented Oct 5, 2026

Uh oh!

saethlin commented Oct 5, 2026

Uh oh!

This comment was marked as outdated.

dianqk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dianqk commented Oct 6, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

Uh oh!

rust-timer commented Oct 8, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Oct 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dianqk left a comment •

edited by rustbot

Loading