even more `tests/crashes` migration for `-Znext-solver` by lcnr · Pull Request #163806 · rust-lang/rust

lcnr · 2026-10-05T13:19:41Z

cc https://hackmd.io/ydc_nIbHQqG-ctMDapXYTg continuing the work of #163796

relevant issues:

ICE: unhandled type: Alias(...) in rustc_mir_transform/src/validate.rs when [mir_built] #126680 still broken due to Body::typing_env is incorrect during early analysis trait-system-refactor-initiative#303
ICE：rustc panicked at compiler\rustc_mir_transform\src\validate.rs:1560:30 #140850
ICE: could not resolve upvar: LocalVarId(HirId(DefId))) #125553
ICE: {OpaqueTypeKey { def_id: DefId .. #123157 duplicate of ICE: could not resolve upvar: LocalVarId(HirId(DefId))) #125553
ICE: Unsize coercion, but &dyn Foo<'_> isn't coercible to &dyn Bar<'_, '_, ()> #131886 still broken due to Body::typing_env is incorrect during early analysis trait-system-refactor-initiative#303
ICE: "Missing value for constant, but no error reported?" with unresolvabe const due to trivial bounds #135617
ICE with higher order associated types #129372
ICE while trying to field project out of opaque value by utilizing type ascription #134838
Broken MIR in DefId (TerminatorKind::Call with GATs) #131373
ICE: error from fully_perform, with HRTB on GAT #136666 duplicate of ICE: error performing ParamEnvAnd { ... } possibly related to (lack of) HRTBs in closures #124440
error: internal compiler error: compiler/rustc_infer/src/infer/lexical_region_resolve/mod.rs:486:17: cannot relate region: LUB('{erased}, '{erased}) #127033
ICE: "error performing operation: fully_perform" on type inference for trait object with HRTB over GAT #130797 duplicate of incompletely relating alias args may cause borrowck ICE #140211
ICE: assertion failed: !ty.has_non_region_infer() #135122
ICE: "failed to resolve instance for type", apparently caused by generic parameter inference #135718
ICE: !a.has_escaping_bound_vars() #139381
error performing operation: fully_perform in ascribe_user_type #138707
ICE: broken MIR: NoSolution on HRTB over GAT in trait object #130524 duplicate of incompletely relating alias args may cause borrowck ICE #140211
ICE: Creating trait object of wrapper struct of a async closure with non-generic arugment and generic arguments with multiple allowed arities #147719 instance of broken MIR in DefId(...) (NoSolution) #110534
ICE: broken mir: Unsize coercion .. isn't coercible #148094 duplicate of ICE: Unsize coercion, but &dyn Foo<'_> isn't coercible to &dyn Bar<'_, '_, ()> #131886
ICE: failed to resolve instance for <fn(FooImpl, ()) as FooFn>::bar #139120 duplicate of incompletely relating alias args may cause borrowck ICE #140211
SignatureMismatch ICE #146965 instance of param-env shadowing can cause goals to fail lcnr/random-rust-snippets#23
ICE: impl xxx was matchable against Binder xxx but now is not #149015
ICE: self.query_mode == TraitQueryMode::Canonical #148095
ICE in release builds from 1.90.0 onwards #150263 duplicate of SignatureMismatch ICE #146965
ICE: impl .. was matchable against Binder { .. } but now is not #150517 duplicate of ICE: impl xxx was matchable against Binder xxx but now is not #149015
ICE: SizeSkeleton::compute panics on complex recursive type alias involving Pointee::Metadata #151069

lcnr · 2026-10-06T09:45:05Z

r? lqd i guess :3

rustbot · 2026-10-06T09:45:10Z

lqd is not on the review rotation at the moment.
They may take a while to respond.

rustbot · 2026-10-06T09:45:41Z

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

lqd

👍

View changes since this review

lqd · 2026-10-06T13:37:41Z

+//@[old] known-bug: #135617
+
+// The bound `for<'a> (): Project` prevents us from normalizing the
+// array length. This caused and ICE with the new solver. The actual


Did you mean "This caused an ICE with the old solver"?

lqd · 2026-10-06T13:39:09Z

+//@[next] compile-flags: -Znext-solver
+//@[old] failure-status: 101
+//@[old] dont-check-compiler-stderr
+//@[old] known-bug: #140850
+//@[next] check-pass


_{(if we end up modifying anything in this PR, let's also regroup the two next directives together so it's slightly easier to read)}

lqd · 2026-10-06T13:40:04Z

+//@[next] compile-flags: -Znext-solver
+//@[old] failure-status: 101
+//@[old] dont-check-compiler-stderr
+//@[old] known-bug: #125553
+//@[next] check-pass


_{(here as well, if we end up modifying anything in this PR, let's also regroup the two next directives together so it's slightly easier to read)}

rustbot · 2026-10-06T15:46:51Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

lcnr · 2026-10-06T16:24:19Z

@bors r=lqd rollup=iffy (lots of test, otherwise safe)

rust-bors · 2026-10-06T16:24:22Z

📌 Commit 579a6bd has been tentatively approved by lqd

It will be put into the queue for this repository once PR CI succeeds.

…uwer Rollup of 25 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #162156 (add IBM f128 type) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

…uwer Rollup of 24 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

…uwer Rollup of 23 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

Rollup merge of #163806 - lcnr:crashes-migration-cont, r=lqd even more `tests/crashes` migration for `-Znext-solver` cc https://hackmd.io/ydc_nIbHQqG-ctMDapXYTg continuing the work of #163796 relevant issues: - #126680 still broken due to rust-lang/trait-system-refactor-initiative#303 - #140850 - #125553 - #123157 duplicate of #125553 - #131886 still broken due to rust-lang/trait-system-refactor-initiative#303 - #135617 - #129372 - #134838 - #131373 - #136666 duplicate of #124440 - #127033 - #130797 duplicate of #140211 - #135122 - #135718 - #139381 - #138707 - #130524 duplicate of #140211 - #147719 instance of #110534 - #148094 duplicate of #131886 - #139120 duplicate of #140211 - #146965 instance of lcnr/random-rust-snippets#23 - #149015 - #148095 - #150263 duplicate of #146965 - #150517 duplicate of #149015 - #151069

rust-timer · 2026-10-08T09:14:53Z

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (169ad55): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	2
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	6
All ❌✅ (primary)	-0.1%	[-0.1%, -0.1%]	2

Max RSS (memory usage)

Results (secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.0%]	2
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Artifact size: 408.59 MiB -> 408.58 MiB (-0.00%)

JonathanBrouwer · 2026-10-08T16:24:29Z

This is noise, all PRs in the rollup have the same results

…uwer Rollup of 23 pull requests Successful merges: - rust-lang/rust#163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - rust-lang/rust#163806 (even more `tests/crashes` migration for `-Znext-solver`) - rust-lang/rust#163508 (Document the `rustc_on_unimplemented` attribute.) - rust-lang/rust#163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - rust-lang/rust#163863 (use the type name instead of `Self` in constructor paths again) - rust-lang/rust#163864 (Remove CLAUDE.md) - rust-lang/rust#163877 (Add regression test for duplicated rustdoc search results between std and core) - rust-lang/rust#163916 (Shrink `PartialRes` and its alignment) - rust-lang/rust#149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - rust-lang/rust#152557 (Oneshot `is_ready`) - rust-lang/rust#157273 (Stabilize `optimize` attribute) - rust-lang/rust#162000 (peel_transparent_wrappers only works on non-1ZST) - rust-lang/rust#163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - rust-lang/rust#163348 (perf:cache FFI safety results in improper_ctypes lint) - rust-lang/rust#163768 (Move more `rustdoc-html` tests in the right location) - rust-lang/rust#163778 (check is_indirect_first_projection when replacing in RefProp) - rust-lang/rust#163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - rust-lang/rust#163807 (Add `has_reliable_f16b` for Arm) - rust-lang/rust#163809 (Switch TLS implementation for wasi and bump SDK version to 34) - rust-lang/rust#163826 (Update books) - rust-lang/rust#163849 (ci: update to PowerShell 7.6.6) - rust-lang/rust#163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - rust-lang/rust#163870 (Add if-installed:auto:spellcheck to pre-push script)

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2026

lcnr changed the title ~~even more crashes migration for -Znext-solver~~ even more tests/crashes migration for -Znext-solver Oct 5, 2026

This comment has been minimized.

Sign in to view

lcnr force-pushed the crashes-migration-cont branch 2 times, most recently from 03239a7 to 5746876 Compare October 5, 2026 13:50

rustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Oct 5, 2026

lcnr force-pushed the crashes-migration-cont branch 2 times, most recently from 03f305a to 5d2cae8 Compare October 5, 2026 21:26

This comment has been minimized.

Sign in to view

lcnr force-pushed the crashes-migration-cont branch from a4adff6 to 6b1c59c Compare October 6, 2026 08:01

lcnr mentioned this pull request Oct 6, 2026

ICE: Creating trait object of wrapper struct of a async closure with non-generic arugment and generic arguments with multiple allowed arities #147719

Open

lcnr force-pushed the crashes-migration-cont branch 2 times, most recently from e9927bf to a16249d Compare October 6, 2026 09:00

rustbot assigned lqd Oct 6, 2026

lcnr marked this pull request as ready for review October 6, 2026 09:45

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 6, 2026

lqd approved these changes Oct 6, 2026

View reviewed changes

lcnr added 8 commits October 6, 2026 17:16

continue next-solver crashes triage

3bc8827

cont tests/crashes migration

5c5254e

remove duplicate test

ee6d48c

more things which no longer ICE

d84ec36

more next-solver crashes migration

b7763ca

more crashes tests

e79214f

more tests :3

be29dc2

one more crashes test

88cd166

lcnr added 3 commits October 6, 2026 17:16

yeet duplicate test

89242d8

crashes migration

ab3e7ce

review

579a6bd

lcnr force-pushed the crashes-migration-cont branch from f4b8aae to 579a6bd Compare October 6, 2026 15:46

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2026

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 25 pull requests #163919

Closed

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 24 pull requests #163934

Closed

lcnr mentioned this pull request Oct 7, 2026

use pre-borrowck typing env for early MIR validation #163813

Merged

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 23 pull requests #163957

Merged

rust-bors Bot merged commit 1760e75 into rust-lang:main Oct 8, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 8, 2026

lcnr mentioned this pull request Oct 8, 2026

Stabilize the next-generation trait solver rust-lang/goals#113

Open

lcnr deleted the crashes-migration-cont branch October 8, 2026 20:19

github-actions Bot mentioned this pull request Oct 9, 2026

Toolchain upgrade to nightly-2026-10-09 flux-rs/flux#1811

Draft

Conversation

lcnr commented Oct 5, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

lcnr commented Oct 6, 2026

Uh oh!

rustbot commented Oct 6, 2026

Uh oh!

rustbot commented Oct 6, 2026

Uh oh!

lqd left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lqd Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

lqd Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

lqd Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Oct 6, 2026

Uh oh!

lcnr commented Oct 6, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

Uh oh!

rust-timer commented Oct 8, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Oct 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lcnr commented Oct 5, 2026 •

edited by rustbot

Loading

lqd left a comment •

edited by rustbot

Loading