Repository navigation
Rollup of 2 pull requests - #163859
Closed
jhpratt wants to merge 6 commits into
Closed
Rollup of 2 pull requests#163859jhpratt wants to merge 6 commits into
jhpratt wants to merge 6 commits into
Conversation
… r=nnethercote perf:cache FFI safety results in improper_ctypes lint This PR cache FFI safety results in improper_ctypes lint . ImproperCTypesVisitor's cache field is recreated empty at every call site, so a struct type gets fully re-walked from scratch each time instead of once . The implementation here moves the cache onto ImproperCtypesLint, so it remembers types we already checked and found FFI-safe, so we don't check the same type again every time it shows up in another function. We only remember "safe" types, never "unsafe" ones. That way we never need to keep the actual type around, just a fingerprint of it.Thus it persists across a whole module worth of foreign items.
…crichton,clarfonthey Adjust the adjustment to wasi TLS to no longer adjust Fixes rust-lang#163748 Effectively reverts rust-lang#160868 to unrevert the changes to wasi from rust-lang#159733. As explained in rust-lang#160868, now that we use wasi-sdk-34 (since rust-lang#161773), the bug in wasi-libc that motivated the workaround should no longer be an issue. To reflect the fact that we're now relying on version 34, I've also adjusted the minimum SDK version mentioned in the target docs. Note: This could probably be backported to beta, but as this is only a tier 2 target, and 1.99 is already affected by the issue, I don't think this is necessary. cc @alexcrichton r? @clarfonthey
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=5 force |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 5c25829 failed: CI. Failed job:
|
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Member
Author
|
I don't care enough to retry a rollup for the third time. It's only two PRs. |
rust-bors
Bot
added
the
S-waiting-on-author
rustbot
removed
the
S-waiting-on-review
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
r? @ghost
Create a similar rollup