Repository navigation
Rollup of 6 pull requests - #163873
Closed
JonathanBrouwer wants to merge 16 commits into
Closed
Rollup of 6 pull requests#163873JonathanBrouwer wants to merge 16 commits into
JonathanBrouwer wants to merge 16 commits into
Conversation
…ethercote use the type name instead of `Self` in constructor paths again Fixes rust-lang#163800 by restoring `Substructure.type_ident` and using it instead of `Self` for constructor paths in `Clone` and `Default`'s expansions. r? @nnethercote
… r=nnethercote perf:cache FFI safety results in improper_ctypes lint This PR cache FFI safety results in improper_ctypes lint . ImproperCTypesVisitor's cache field is recreated empty at every call site, so a struct type gets fully re-walked from scratch each time instead of once . The implementation here moves the cache onto ImproperCtypesLint, so it remembers types we already checked and found FFI-safe, so we don't check the same type again every time it shows up in another function. We only remember "safe" types, never "unsafe" ones. That way we never need to keep the actual type around, just a fingerprint of it.Thus it persists across a whole module worth of foreign items.
…uppe cg_llvm: Avoid `as_c_char_ptr` in several places As noted in `rustc_codegen_llvm::ffi`: > Normally it's a good idea for Rust-side bindings to match the corresponding C-side function declarations as closely as possible. But when passing `&str` or `&[u8]` data as a pointer/length pair, it's more convenient to declare the Rust-side pointer as `*const c_uchar` instead of `*const c_char`. Both pointer types have the same ABI, and using `*const c_uchar` avoids the need for an extra cast from `*const u8` on the Rust side. The helper method `as_c_char_ptr` exists to make that extra cast more type-safe, but it's nicer to not need it all. In addition to making call sites a bit simpler, this adjustment also makes it harder to accidentally pass a nul-terminated string to a function expecting a pointer/length string, and vice-versa. There should be no change to compiler output.
…, r=folkertdev Add `has_reliable_f16b` for Arm Add the match arm for `has_reliable_f16b` for `Arch::Arm`. Through investigations in llvm/llvm-project#224867 there is decent enough support for Rusts `f16b` type on Arm targets. r? folkertdev
…crichton,clarfonthey Adjust the adjustment to wasi TLS to no longer adjust Fixes rust-lang#163748 Effectively reverts rust-lang#160868 to unrevert the changes to wasi from rust-lang#159733. As explained in rust-lang#160868, now that we use wasi-sdk-34 (since rust-lang#161773), the bug in wasi-libc that motivated the workaround should no longer be an issue. To reflect the fact that we're now relying on version 34, I've also adjusted the minimum SDK version mentioned in the target docs. Note: This could probably be backported to beta, but as this is only a tier 2 target, and 1.99 is already affected by the issue, I don't think this is necessary. cc @alexcrichton r? @clarfonthey
ci: update to PowerShell 7.6.6 This resolves the ICU version issue, because they now support a wide range: PowerShell/PowerShell#26304
rustbot
added
A-CI
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #163809, which is a member of this rollup, was unapproved. This rollup was thus unapproved. |
rustbot
removed
the
S-waiting-on-author
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for 8922476 failed: CI. Failed job:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Selfin constructor paths again #163863 (use the type name instead ofSelfin constructor paths again)as_c_char_ptrin several places #163789 (cg_llvm: Avoidas_c_char_ptrin several places)has_reliable_f16bfor Arm #163807 (Addhas_reliable_f16bfor Arm)r? @ghost
Create a similar rollup