Repository navigation
Rollup of 12 pull requests - #163929
Closed
JonathanBrouwer wants to merge 28 commits into
Closed
Rollup of 12 pull requests#163929JonathanBrouwer wants to merge 28 commits into
JonathanBrouwer wants to merge 28 commits into
Conversation
Co-Authored-By: Ralf Jung <post@ralfj.de>
The `StableHash` implementation for `Path` is used for attributes, which never have generic args. However, nothing *prevents* using `StableHash` for an arbitrary `Path` that might have generic args. Add a check for this and panic. Credit to Nick Nethercote for catching this.
The Reference warns when a `//@ reference:` annotation points to a rule that isn't in the Reference. Some of these had accumulated. Let's clean them up.
This fixes the remaining call sites that were still hard coding values for the key and discriminator. Instead, consult the session to get these values through the schema. This follows the same pattern already used by `get_fn_addr`. No new tests were added, as the existing tests cover this change.
…, r=oli-obk Distinguish `repr(C)` ZSTs from others in ABI computation Implement rust-lang#157973: Some C ABIs pass and return ZSTs by pointer. But `()` should never be returned by pointer, as it must match `void`. To fix this, distinguish `repr(C)` ZSTs (and `repr(transparent)` wrappers around them) from other ZSTs in ABI computation. Fixes rust-lang/unsafe-code-guidelines#552. cc @RalfJung
…joshtriplett Remove `NonOwner` variant from `AstOwner` The refactoring extracted from rust-lang#163495 that should be responsible for memory improvements. And seems logical that enum `AstOwner` should not contain variant `NonOwner`. r? @petrochenkov
Submodule update of rustc-perf To bring in recent changes. r? panstromek
…thercote [PAC] Stop hard coding key and discriminator, consult schema instead This fixes the remaining call sites that were still hard coding values for the `key` and `discriminator`. Instead, consult the `session` to get these values through the `schema`. This follows the same pattern already used by `get_fn_addr`. No new tests were added, as the existing tests cover this change.
…li-obk Include offset in the alignment check when creating ConstValue::Indirect in GVN This is a fix for rust-lang#163782.
explicitly check for fresh vars in canonicalize otherwise we don't detect the bug in rust-lang#148632 with the new solver. r? types
…y789 Don't add pkgs.rustc to PATH in nix dev shell This has annoyed me since I switched to the shell provided by this repo. The `shell.nix` dumps all dependencies of `x` into the shell path, which includes `pkgs.rustc`. The problem is that `pkgs.rustc` from nixpkgs is not managed by rustup, which means it doesn't support specifying the `+toolchain` to compile with. This also breaks the `src/tools/miri/miri` script, since it links a toolchain called `miri` and uses `rustc +miri` in multiple places. This PR makes it so that `rustc` is not added to the env. r? bootstrap
…=nnethercote Panic on `StableHash` of a `Path` with `GenericArgs` The `StableHash` implementation for `Path` is used for attributes, which never have generic args. However, nothing *prevents* using `StableHash` for an arbitrary `Path` that might have generic args. Add a check for this and panic. Credit to Nick Nethercote (@nnethercote) for catching this.
…ations_cleanup-drift, r=PLeVasseur,traviscross Clean up Reference annotations that drifted The Reference warns when a `//@ reference:` annotation points to a rule that isn't in the Reference. Some of these had accumulated. Let's clean them up. r? @PLeVasseur cc @DanielEScherzer (As work within the scope of the lang-docs team, this falls outside the scope of the `forge#1040` policy; nonetheless, I'll note that this work was done with the assistance of AI tools and that this has been prearranged with all reviewers.)
…=Kobzol Remove redundant closure in bootstrap My PR rust-lang#163717 would make Clippy start linting `redundant_closure_for_method_calls` here; let's get ahead of that. @rustbot label T-bootstrap @rustbot ready r? bootstrap
…yUwU abby DSL: implement ambiguity r? @BoxyUwU
rustbot
added
the
A-LLVM
rustbot
added
F-autodiff
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
Rollup of 12 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #156112, which is a member of this rollup, was unapproved. This rollup was thus unapproved. |
rustbot
removed
the
S-waiting-on-author
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for 2099433 failed: CI. Failed jobs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
repr(C)ZSTs from others in ABI computation #156112 (Distinguishrepr(C)ZSTs from others in ABI computation)NonOwnervariant fromAstOwner#163887 (RemoveNonOwnervariant fromAstOwner)StableHashof aPathwithGenericArgs#163893 (Panic onStableHashof aPathwithGenericArgs)Warning
This rollup conflicts with pending auto build #163919 and may need to be recreated if the pending build succeeds.
r? @ghost
Create a similar rollup