Repository navigation
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
amirHdev
force-pushed
the
delegation-inherited-opaques
branch
from
October 8, 2026 12:18
aeb3ddf to
4acc47b
Compare
amirHdev
marked this pull request as ready for review
October 8, 2026 12:19
rustbot
added
S-waiting-on-review
lcnr
reviewed
Oct 8, 2026
| // Their types may also appear in signatures inherited from other items. | ||
| if parent != self.item { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
this doesn't feel ideal. Could we instead explicitly change delegation to never define any opaque types? 🤔
also cc @oli-obk on how to best do stuff here
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes rust-lang/trait-system-refactor-initiative#304
function delegation can inherit opaque return types from the callee
Avoid treating those inherited RPIT and async opaques as if they were defined by the delegation item itself
r? lcnr