Rollup of 4 pull requests by jhpratt · Pull Request #164072 · rust-lang/rust

jhpratt · 2026-10-10T07:55:56Z

Successful merges:

Add documentation for the crate_name attribute #163434 (Add documentation for the crate_name attribute)
Re-enable extension of bool return values on x86_64 #163917 (Re-enable extension of bool return values on x86_64)
Expose regular argument attributes in rustc_public #163242 (Expose regular argument attributes in rustc_public)
cg_llvm: Avoid all remaining uses of as_c_char_ptr #164071 (cg_llvm: Avoid all remaining uses of as_c_char_ptr)

…ibute, r=bushrat011899 Add documentation for the `crate_name` attribute Add documentation for the `crate_name` attribute  Briefly introduces how the attribute works, and things to be careful of when using the attribute. Part of rust-lang#157604

Re-enable extension of bool return values on x86_64 I think this fixes rust-lang#163911 Though the test here is a bit hard to figure out, I'm not sure under what conditions expectation goes in the left or the right column. Do I decide that per-target or per-instance? Because x86_64 seems obligated to extend bool returns, so whether it is a "target that extends" or not depends on the type we're dealing with. I also noticed that because of how the test is written, if codegen starts adding a `zeroext` on a return type where it is wrong to do so, the test will pass anyway.

@makai410

…butes, r=makai410 Expose regular argument attributes in rustc_public Add `ArgAttributes::regular()` and `ArgAttributeFlags` so consumers can read the argument flags already computed by rustc. The conversion preserves all ten flags, including the overlapping capture flags. Clarifies what `pointee_size` guarantees at function entry and return, and how `no_free` affects rustc's emission of LLVM dereferenceability attributes. Fixes rust-lang/rustc_public#132. r? @makai410

…uppe cg_llvm: Avoid all remaining uses of `as_c_char_ptr` Follow-up to: - rust-lang#163789 - rust-lang#164017 --- As explained in the previous PRs (and in the comments for `PTR_LEN_STR`), we can avoid the need for these casts by declaring the relevant FFI bindings to take `*const c_uchar`, which has the same ABI as `*const c_char`. This is more convenient at the call site, and makes it harder to mix up pointer/length strings and nul-terminated strings. There should be no change to compiler output.

jhpratt · 2026-10-10T07:56:12Z

@bors r+ p=5 force

rust-bors · 2026-10-10T07:56:16Z

📌 Commit f43347e has been approved by jhpratt

It is now in the queue for this repository.

rust-bors · 2026-10-10T12:59:45Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 5m 41s
Pushing 5ec56e3 to main...

github-actions · 2026-10-10T13:03:52Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 34f4a80 (parent) -> 5ec56e3 (this PR)

Test differences

Show 232 test diffs

Stage 1

[codegen] tests/codegen-llvm/some-abis-do-extend-params-to-32-bits.rs#x86_64: pass -> [missing] (J0)
[codegen] tests/codegen-llvm/some-abis-do-extend-params-to-32-bits.rs#x86_64-linux: [missing] -> pass (J0)
[codegen] tests/codegen-llvm/some-abis-do-extend-params-to-32-bits.rs#x86_64-uefi: [missing] -> pass (J0)

Stage 2

[codegen] tests/codegen-llvm/some-abis-do-extend-params-to-32-bits.rs#x86_64: pass -> [missing] (J1)
[codegen] tests/codegen-llvm/some-abis-do-extend-params-to-32-bits.rs#x86_64-linux: [missing] -> pass (J1)
[codegen] tests/codegen-llvm/some-abis-do-extend-params-to-32-bits.rs#x86_64-uefi: [missing] -> pass (J1)

Additionally, 226 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5ec56e3902656f2460259fc3ac0f6e2255f94417 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-x86_64-gnu-miri: 48m 40s -> 1h 29m (+84.0%)
test-pr-check-1: 22m 12s -> 40m 43s (+83.4%)
test-armhf-gnu: 58m 5s -> 1h 40m (+73.0%)
test-i686-gnu-nopt-2: 1h 21m -> 2h 17m (+69.9%)
test-x86_64-msvc-2: 1h 35m -> 2h 41m (+68.0%)
test-x86_64-gnu-tools: 42m 10s -> 1h 10m (+67.1%)
test-x86_64-gnu-aux: 1h 47m -> 2h 42m (+52.1%)
test-x86_64-gnu-parallel-frontend: 1h 21m -> 2h 2m (+51.5%)
test-x86_64-gnu-llvm-22-3: 1h 17m -> 1h 56m (+49.2%)
dist-x86_64-freebsd: 1h 3m -> 1h 34m (+49.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-bors · 2026-10-10T14:01:40Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#163434	Add documentation for the `crate_name` attribute	`57e44be282b873725747c3a400e4e1f343916262` (link)
#163917	Re-enable extension of bool return values on x86_64	`1f8b8b29f795bf0e8a5a96bdcd54f556f28e3266` (link)
#163242	Expose regular argument attributes in rustc_public	`c0523347d2632ae296fb8efcf3368de898ceb928` (link)
#164071	cg_llvm: Avoid all remaining uses of `as_c_char_ptr`	`0534904ed0ff8f1f233b1e08327f6de95880548d` (link)

parent commit: 34f4a807e2

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

rust-timer · 2026-10-10T14:14:09Z

Finished benchmarking commit (5ec56e3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.0%, secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.8%	[0.7%, 2.8%]	10
Regressions ❌ (secondary)	3.8%	[0.9%, 9.3%]	20
Improvements ✅ (primary)	-1.4%	[-2.5%, -0.9%]	3
Improvements ✅ (secondary)	-7.6%	[-10.3%, -4.2%]	5
All ❌✅ (primary)	1.0%	[-2.5%, 2.8%]	13

Cycles

Results (secondary 1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.9%	[5.7%, 11.2%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.1%	[-10.7%, -3.6%]	2
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.09s -> 487.044s (-0.42%)
Artifact size: 406.52 MiB -> 406.45 MiB (-0.02%)

saethlin and others added 12 commits October 6, 2026 23:53

Add test coverage

294ff0f

Fix the bug by enabling extension for bool returns on x86_64

a0f1885

rustc_public: expose regular argument attributes

6d201c4

rustc_public: improve ABI test failure context

b7b52cb

rustc_public: wrap ABI test assertions for tidy

a543a14

rustc_public: update pointee size test and docs

8a0c5b6

Avoid all remaining uses of as_c_char_ptr

f935b44

Add documentation for the crate_name attribute

f6b09cd

rust-bors Bot added the rollup A PR which is a rollup label Oct 10, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2026

rust-bors Bot merged commit 5ec56e3 into rust-lang:main Oct 10, 2026
15 checks passed

rustbot added this to the 1.101.0 milestone Oct 10, 2026

jhpratt deleted the rollup-vxzS1nR branch October 12, 2026 01:15

Navigation Menu

Repository navigation

Rollup of 4 pull requests - #164072

Rollup of 4 pull requests#164072
rust-bors[bot] merged 12 commits into
rust-lang:mainfrom
jhpratt:rollup-vxzS1nR

jhpratt commented Oct 10, 2026

Uh oh!

jhpratt commented Oct 10, 2026

Uh oh!

rust-bors Bot commented Oct 10, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 10, 2026

Stage 1

Stage 2

Uh oh!

rust-bors Bot commented Oct 10, 2026

Uh oh!

rust-timer commented Oct 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

jhpratt commented Oct 10, 2026

Uh oh!

jhpratt commented Oct 10, 2026

Uh oh!

rust-bors Bot commented Oct 10, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 10, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-bors Bot commented Oct 10, 2026

Uh oh!

rust-timer commented Oct 10, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants