Fix all non-bug lints. Switch to `let` statements. - #56956

Closed

JohnHeitmann wants to merge 124 commits into

rust-lang:masterfrom

JohnHeitmann:lints-submit

Commits on Dec 29, 2018

Fix all non-bug lints
JohnHeitmann
committed
9691ad0
Use let instead of var, except for globals.
JohnHeitmann
committed
2878ab8

Commits on Jan 2, 2019

Clean up eslint pragma formatting
JohnHeitmann
committed
8c304d3

Commits on Jan 5, 2019

Use checked_add for adding time in recv_timeout

faern
authored and
JohnHeitmann
committed
aa429bd
Add documentation about panicking Add<Duration> impls

faern
authored and
JohnHeitmann
committed
e1f7cd8
Uninline some debugging code and use unlikely! macro

Zoxc
authored and
JohnHeitmann
committed
2f9d3c7
Store `Ident` rather than just `Name` in HIR types `Item` and `ForeignItem`.

alexreg
authored and
JohnHeitmann
committed
44ba1e9
Implemented variants on type aliases in both ctor and pattern position.

alexreg
authored and
JohnHeitmann
committed
4748dc5
Added tests for feature.

alexreg
authored and
JohnHeitmann
committed
711af86
Made suggestion diagnostics more consistent for enum variant names, relative to method names.

alexreg
authored and
JohnHeitmann
committed
9fcbf24
Fixed tests.

alexreg
authored and
JohnHeitmann
committed
4137376
Fixed more tests.

alexreg
authored and
JohnHeitmann
committed
c85edb8
Added chapter to Unstable Book.

alexreg
authored and
JohnHeitmann
committed
f30d29a
Fixed issues raised in first review.

alexreg
authored and
JohnHeitmann
committed
12b64b6
Work-around for shadowing of variant names with assoc const names in `libproc_macro/bridge/rpc.rs`.

alexreg
authored and
JohnHeitmann
committed
06b716e
Added tests for enums & enum aliases with various combinations of generic args.

alexreg
authored and
JohnHeitmann
committed
2eeb932
Fixed issues raised in review.

alexreg
authored and
JohnHeitmann
committed
f370436
Expanded tests for enum variants with generic args.

alexreg
authored and
JohnHeitmann
committed
f74f949
Removed unnecessary special handling of `VariantCtor` defs in `instantiate_value_path`.

alexreg
authored and
JohnHeitmann
committed
8b6769c
Fixed several ICEs.

alexreg
authored and
JohnHeitmann
committed
72d498d
Added regression test for using generic parameters on modules.

alexreg
authored and
JohnHeitmann
committed
89a33dd
Fixed handling of unit variants of aliased enums in type NS.

alexreg
authored and
JohnHeitmann
committed
f79535b
Fixed type inference for tuple struct variants.

alexreg
authored and
JohnHeitmann
committed
8fec007
Fixed ICE when type arguments are specified on `Self` type.

alexreg
authored and
JohnHeitmann
committed
0f3f0b8
Minor clean-up

alexreg
authored and
JohnHeitmann
committed
66ee7c4
Minor cosmetic changes

alexreg
authored and
JohnHeitmann
committed
2445f43
Changed resolution of enum variants to low priority.

alexreg
authored and
JohnHeitmann
committed
92e3a35
Point at correct span for arguments in format strings

estebank
authored and
JohnHeitmann
committed
21a012a
Add span label to unused string formatting argument

estebank
authored and
JohnHeitmann
committed
936ea70
retrieve ty info from place_ty

csmoe
authored and
JohnHeitmann
committed
acb04c1
Fix typo in pin documentation

sgrif
authored and
JohnHeitmann
committed
fa563d5
Fix span in char documentation

estebank
authored and
JohnHeitmann
committed
65819ce
Update references to closed issue

ids1024
authored and
JohnHeitmann
committed
efd19d5
resolve: Fix an ICE in import validation

petrochenkov
authored and
JohnHeitmann
committed
3751654
Give the crate select chevron room to breathe.
JohnHeitmann
committed
b4d18a2
Removed aligned ZST requirement from docs of read_/write_unaligned.

kennytm
authored and
JohnHeitmann
committed
2cb1ece
Update link to rustc guide

linclark
authored and
JohnHeitmann
committed
6a3d95e
Suggest `.as_ref()` when appropriate for `Option` and `Result`

estebank
authored and
JohnHeitmann
committed
00ef955
Clarify wording of E0512

varkor
authored and
JohnHeitmann
committed
e3db7ee
Add specific diagnostic for transmuting between equal associated types

varkor
authored and
JohnHeitmann
committed
9e15f42
Fix warning when compiling rustc

varkor
authored and
JohnHeitmann
committed
c7e83ba
remove remaining copyright headers

matthiaskrgr
authored and
JohnHeitmann
committed
07f6432
resolve: Fix another ICE in import validation

petrochenkov
authored and
JohnHeitmann
committed
2c3d194
resolve: Never override real bindings with `Def::Err`s from error recovery

petrochenkov
authored and
JohnHeitmann
committed
42730aa
Update cargo, rls, miri

ehuss
authored and
JohnHeitmann
committed
7848878
add non-copy note to stderr

csmoe
authored and
JohnHeitmann
committed
2b7ff35
Fixed stderr files for ui tests.

alexreg
authored and
JohnHeitmann
committed
9b9fd03
update tests line numbers

matthiaskrgr
authored and
JohnHeitmann
committed
c1bea3b
resolve: Simplify treatment of ambiguity errors

petrochenkov
authored and
JohnHeitmann
committed
643e4e6
Use `same_type` instead of duplicating logic

estebank
authored and
JohnHeitmann
committed
f5f5d4c
Remove mention of required memory to build

nagisa
authored and
JohnHeitmann
committed
87a4d21
Improve error recovery for some built-in macros

petrochenkov
authored and
JohnHeitmann
committed
111bcb1
Make std::cmp::Ord documentation specify what it means to agree with PartialEq

czipperz
authored and
JohnHeitmann
committed
a5b93f0
Specify criterion for PartialOrd

czipperz
authored and
JohnHeitmann
committed
6090b31
Mention ToString in std::fmt docs

czipperz
authored and
JohnHeitmann
committed
faaae93
Do not complain about missing crate named as a keyword

estebank
authored and
JohnHeitmann
committed
c22ee1a
Refactor `UserTypeAnnotation`.

davidtwco
authored and
JohnHeitmann
committed
cceb1f7
Always check well-formedness.

davidtwco
authored and
JohnHeitmann
committed
43538cb
Add test for unreachable well-formedness.

davidtwco
authored and
JohnHeitmann
committed
7fc1fee
Type annotations in associated constant patterns.

davidtwco
authored and
JohnHeitmann
committed
1681b2d
Add user type annotations to MIR dump.

davidtwco
authored and
JohnHeitmann
committed
70ffd8d
Support user type annotations in `ref` bindings.

davidtwco
authored and
JohnHeitmann
committed
5e75340
Add explicit error annotations to test.

davidtwco
authored and
JohnHeitmann
committed
3507013
Fix unresolved inference variable ICE.

davidtwco
authored and
JohnHeitmann
committed
ae43eec
Stop well-formedness checking unreachable code.

davidtwco
authored and
JohnHeitmann
committed
ac18fbb
Stop duplicating projections of type annotation.

davidtwco
authored and
JohnHeitmann
committed
ab2a785
Guarantee `rustc_dump_user_substs` error order.

davidtwco
authored and
JohnHeitmann
committed
5d760c0
submodules: update clippy from f7bdf500 to 39bd8449

matthiaskrgr
authored and
JohnHeitmann
committed
2a7cc8e
Add `-Z instrument-mcount`

quark-zju
authored and
JohnHeitmann
committed
0012941
Address review comments: Remove new `PathResult` variant

estebank
authored and
JohnHeitmann
committed
5345ae9
Fix variable string size problem in transmute test

varkor
authored and
JohnHeitmann
committed
9f0925d
Group dep node data into a single structure

Zoxc
authored and
JohnHeitmann
committed
1ea7f96
Use `entry` API to avoid double lookup when interning dep nodes

Zoxc
authored and
JohnHeitmann
committed
c5cba54
Address comments

Zoxc
authored and
JohnHeitmann
committed
216e8cc
Fix inconsistent Clone documentation.

doitian
authored and
JohnHeitmann
committed
21e0948
Suggest using raw identifiers in 2018 edition when using keywords

estebank
authored and
JohnHeitmann
committed
7e454d2
Address review comments

estebank
authored and
JohnHeitmann
committed
9ee58ff
Update tests after rebase

estebank
authored and
JohnHeitmann
committed
fdedfc0
Account for `\xFF` and `\u{FF}` sequences in string format errors

estebank
authored and
JohnHeitmann
committed
7cf4468
Use structured suggestion for braceless unicode escape squence

estebank
authored and
JohnHeitmann
committed
73ba9d8
use structured suggestions for nonexistent fields

euclio
authored and
JohnHeitmann
committed
0ed7ced
Do not use unicode character in diagnostic help

estebank
authored and
JohnHeitmann
committed
4b57fea
privacy: Use common `DefId` visiting infra for all privacy visitors

petrochenkov
authored and
JohnHeitmann
committed
3d0bcd2
Address review comments

petrochenkov
authored and
JohnHeitmann
committed
e4bab0e
Bound sgx target_env with fortanix as target_vendor

dingelish
authored and
JohnHeitmann
committed
303e440
Improve type mismatch error messages

codeworm96
authored and
JohnHeitmann
committed
df9f594
Remove min_const_unsafe_fn since it is stable

dingelish
authored and
JohnHeitmann
committed
98d4589
syntax: Fix regression in diagnostics for patterns in trait method parameters

petrochenkov
authored and
JohnHeitmann
committed
b25abf1
generate invalidations from 2-phase-borrow activations

nikomatsakis
authored and
JohnHeitmann
committed
454f7cb
adopt polonius-engine 0.6.2

nikomatsakis
authored and
JohnHeitmann
committed
4bb9ecd
Wf-check the output type of a function in MIR-typeck

matthewjasper
authored and
JohnHeitmann
committed
ce6192c
Add missing 'static bound for the Machine trait

matthewjasper
authored and
JohnHeitmann
committed
9c9411a
remove `commit_if_ok` wrapper

nikomatsakis
authored and
JohnHeitmann
committed
db29f09
remove wrapper functions that had no purpose

nikomatsakis
authored and
JohnHeitmann
committed
a7ec107
make evaluation track whether outlives relationships mattered

nikomatsakis
authored and
JohnHeitmann
committed
89ad572
introduce ability to detect region constraints from snapshot

nikomatsakis
authored and
JohnHeitmann
committed
1e89f28
select.rs: unsizing coercion should use a subtype

nikomatsakis
authored and
JohnHeitmann
committed
9e8fa85
WIP: wfcheck ability to detect

nikomatsakis
authored and
JohnHeitmann
committed
254d1a4
universe transition

nikomatsakis
authored and
JohnHeitmann
committed
b46812b
add tests exercising `exists<'a> { forall<'b> { .. } }` pattern

nikomatsakis
authored and
JohnHeitmann
committed
8165541
tests: move coherence-subtyping from run-pass to compile-fail

nikomatsakis
authored and
JohnHeitmann
committed
1423a67
tests: worse diagnostics, but basically same errors

nikomatsakis
authored and
JohnHeitmann
committed
c1cd912
tests: cases where we now do the right thing but did not before

nikomatsakis
authored and
JohnHeitmann
committed
a0ccf99
WIP other test changes

nikomatsakis
authored and
JohnHeitmann
committed
581dc66
remove outdated `rustc_driver` tests

nikomatsakis
authored and
JohnHeitmann
committed
616898f
make `get_highlight_region_for_regionvid` only affect re-vid

nikomatsakis
authored and
JohnHeitmann
committed
94123f2
dump out the exact state in error reporting debugs

nikomatsakis
authored and
JohnHeitmann
committed
d354e85
generalize region highlights into a struct

nikomatsakis
authored and
JohnHeitmann
committed
b412851
add the ability to highlight placeholders

nikomatsakis
authored and
JohnHeitmann
committed
749b6fb
introduce placeholder-placeholder errors for trait matching

nikomatsakis
authored and
JohnHeitmann
committed
b53e7e3
apply the new placeholder errors even with just one placeholder

nikomatsakis
authored and
JohnHeitmann
committed
d3a8d6d
refactor highlighting to take any RegionKind, making it more general

nikomatsakis
authored and
JohnHeitmann
committed
3744f87
apply the same logic to ConcreteFailure errors

nikomatsakis
authored and
JohnHeitmann
committed
deb0366
say "the lifetime" instead of "some lifetime" when it feels right

nikomatsakis
authored and
JohnHeitmann
committed
d4fb139
improve handling for subtype

nikomatsakis
authored and
JohnHeitmann
committed
e9ba964
pacify the mercilous tidy

nikomatsakis
authored and
JohnHeitmann
committed
6d6f12e
address tmandry nits

nikomatsakis
authored and
JohnHeitmann
committed
57f76be
add some comments about lifetimes etc

nikomatsakis
authored and
JohnHeitmann
committed
a90bd6c
pacify the mercilous eddyb ;)

nikomatsakis
authored and
JohnHeitmann
committed
500c093
track if any region constraints involved placeholders

nikomatsakis
authored and
JohnHeitmann
committed
0c81a2f
try to detect affected code and direct people to #56105

nikomatsakis
authored and
JohnHeitmann
committed
f17caab
rename `type_moves_by_default` to `type_is_copy_modulo_regions`

nikomatsakis
authored and
JohnHeitmann
committed
96640ad
Add optional eslint to the rustdoc-js test target
JohnHeitmann
committed
0303de6
Delete buggy code that is probably dead
JohnHeitmann
committed
1c029f4