fix(windows): fix URL handling when opening browser - #5119
Merged
Merged
Conversation
rami3l
marked this pull request as ready for review
September 29, 2026 14:07
djc
approved these changes
Sep 29, 2026
|
Checked out af4c8c2 and can confirm that the issue is resolved. Running cargo run-rustup -- doc --book
cargo run-rustup -- doc --rustdoc
cargo run-rustup -- doc --rustdoc lints::broken_intra_doc_links
cd target\debug
$env:RUSTUP_FORCE_ARG0="rustup"
./rustup-init doc --book
./rustup-init doc --rustdoc
./rustup-init doc --rustdoc lints::broken_intra_doc_linksHappy to see this fixed! |
ChrisDenton
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5035 by:
openerto a newer version that includes Fix Windows file URL handling and browser fragment preservation Seeker14491/opener#44.Many thanks to @ChrisDenton for investigating into this issue and @Seeker14491 for making the upstream fix!
cc @SnipUndercover if you want to do another round of testing with the two commands below: