add CI check for MSRV, fix errors - #152
Merged
Merged
Conversation
syphar
force-pushed
the
toolchain-test
branch
from
September 12, 2026 14:15
e2a68d1 to
4956d2f
Compare
syphar
marked this pull request as ready for review
September 12, 2026 14:15
syphar
force-pushed
the
toolchain-test
branch
from
September 12, 2026 14:27
4956d2f to
ecfb4ff
Compare
Member
Author
GuillaumeGomez
approved these changes
Sep 12, 2026
Member
|
Good idea, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not 100% certain if just running
cargo checkshould be good enough to confirm the MSRV is good?In any case, I already found issues where
rust-version = "1.89"didn't hold true, at least for tests. As library user I think we were fine.