Fix macOS build with modern clang/Xcode - #132
Open
joaomcarlos wants to merge 1 commit into
Open
joaomcarlos wants to merge 1 commit into
joaomcarlos wants to merge 1 commit into
Conversation
- bump ui-sys bindgen 0.54 -> 0.72: bindgen 0.54 panics on clang 16+
("enum_(unnamed_at...)" is not a valid Ident)
- add darwin/event.m to ui-sys source list: main.m references
uiprivSendKeyboardEditEvents which lives in event.m, causing an
arm64 link failure
- fix usize/u64 casts in iui: newer bindgen generates usize fields
for NumStops/NumDashes/Size
Verified on macOS 26 arm64 (Apple clang 21) building qft --features gui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui-sysbindgen 0.54 -> 0.72: bindgen 0.54 panics on clang 16+ ("enum_(unnamed_at__/libui/ui_h_53_1)" is not a valid Ident)darwin/event.mto theui-syssource list:main.mreferencesuiprivSendKeyboardEditEvents(defined inevent.m), causing an undefined-symbol link failure on arm64usize/u64casts iniui(brush.rs,strokeparams.rs,ui.rs): newer bindgen generatesusizefields forNumStops/NumDashes/SizeContext
Found while trying to
cargo install --git https://github.com/tudbut/qft --features guion macOS 26 arm64 (Apple clang 21). The build failed insideui-sys, then again at link time, then iniui— each fix surfaced the next error. With all three applied, qft compiles andqft guilaunches correctly.Test plan
cargo buildon macOS 26 arm64 (Apple clang 21) succeedstudbut/qft --features guiagainst this tree and launchingqft guiNote: related to #131