Conversation
`AddressMessageBuilder` and `AddressAddRequest` have no method to set `ifa_scope`, `IFA_FLAGS`, peer, broadcast, anycast, label, route priority, cache information and protocol, which are required by the `ip address add` command of iproute2. Users have to modify the message with `message_mut()` to append the attributes manually. Add builder methods for all of them, so iproute-rs can construct address messages without touching raw attributes. Signed-off-by: Gris Ge <cnfourt@gmail.com>
cathay4t
enabled auto-merge (rebase)
October 1, 2026 01:48
cathay4t
disabled auto-merge
October 1, 2026 01:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddressMessageBuilderandAddressAddRequesthave no method to setifa_scope,IFA_FLAGS, peer, broadcast, anycast, label, routepriority, cache information and protocol, which are required by the
ip address addcommand of iproute2. Users have to modify the messagewith
message_mut()to append the attributes manually.Add builder methods for all of them, so iproute-rs can construct address
messages without touching raw attributes.