Clarify signed-zero behavior in Signed predicate documentation - #387
Open
RanaPriyansh wants to merge 1 commit into
Open
RanaPriyansh wants to merge 1 commit into
RanaPriyansh wants to merge 1 commit into
Conversation
RanaPriyansh
force-pushed
the
docs/signed-zero-385
branch
from
September 24, 2026 09:44
2eb3453 to
5e5e060
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed::is_positiveandSigned::is_negativedocument zero as neither positive nor negative. Forf32andf64, the existing implementations instead inspect the sign bit, including signed zero.Distinguish integer and floating-point behavior in the trait documentation. Add doctests that call
Signedexplicitly for both float types and integer-zero controls. Runtime behavior is unchanged.Related to #385.
Verification on Rust 1.94.1:
RUSTDOCFLAGS='-D warnings'for default features, no default features, andlibmwithout default features.ci/test_full.shfeature-matrix script passed before the final wording-only precision edit. Documentation and doctests were rerun on the final source.The upstream MSRV and platform matrix was not run locally. AI-assisted implementation and verification; independent agent review.