Repository navigation
chore(cli,mcp,lib,ci,docs)!: move coverage functionality to patchcov - #2202
Merged
Merged
Conversation
Remove the coverage command tree, library module, MCP tool, dedicated fixtures and repository configuration now maintained by patchcov. Upgrade the coverage action to its published patchcov-based v2.0 while keeping the Coverage check name and line gate. Migrate existing source markers so exclusions still apply, remove the old build-script lint, and update help snapshots, documentation and the retired scope fixture. BREAKING CHANGE: replace omni-dev coverage commands with patchcov diff, merge and lint-markers. The coverage_diff MCP tool and omni_dev::coverage library module are removed. Source markers now use patchcov: coverage. Closes #2200
CoverageTotal: 97.93% 🟢 0.1 pp vs Comparing
🔇 269 ignored region(s), 0 tolerated region(s)
Patch coverageNo new executable lines added by this diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove coverage functionality now maintained in rust-works/patchcov. The CLI no longer advertises or accepts
coverage, the library no longer exportsomni_dev::coverage, and MCP no longer registerscoverage_diff.CI uses the already-published
action-works/omni-dev-coverage-check@v2.0, which installs patchcov 0.1.1. TheCoveragecheck name, 30% line gate, PR comment and baseline settings stay intact.Type of Change
Related Issue
Closes #2200
Implementation plan
Changes Made
.omni-dev/coverage.yaml, anddocs/coverage.md.patchcov: coverage, preserving regions and reasons; remove the old build-script marker lint.Testing
Commands run from the explicit issue worktree, with explicit manifest paths for standalone Cargo commands:
bash scripts/build.sh: build, formatting, all-target/all-feature Clippy with-D warnings, and default tests pass (13,157 passed; one ignored).cargo test --features mcp: passes (14,047 passed; one ignored), including tool inventory and help snapshot checks.cargo doc --no-deps --document-private-items: passes, emitting 172 rustdoc warnings.actionlint .github/workflows/ci.yml,bash -n scripts/build.sh,git diff --check: pass.patchcov lint-markers -C "$WT" --include '**/*.rs'passes; downloaded binary checksum verified.omni-dev config scopes lint --root src --root editors --root .github: 675 files, zero violations.python3 scripts/check_changelog.py --base origin/main: pass.coveragewith exit code 2.cargo package --allow-dirty --no-verify --offline: 9.8 MiB compressed, below the 10 MiB cap. Packaging warns about the intentionally excluded evaluation example and yankedchacha20 0.10.0in the existing lockfile.The first MCP run failed index-based scope lint before deletions were staged; the rerun passes. A sandboxed default run failed mock-server socket tests and hung; it was stopped, and the full script passes with local socket access. GitHub CI supplies hosted coverage results and Linux/Windows validation; no local coverage percentage is claimed.
Checklist
origin/main...HEADPerformance Impact
Coverage-only code is removed; remaining runtime logic is unchanged. No benchmarks needed.
Security Considerations
No authentication or data-handling behavior changes. Existing shared dependencies retain callers (including quick-xml in launchd support).
Breaking Changes
Replace
omni-dev coverage diff,mergeandlint-markerswith the correspondingpatchcovcommands. Replace coverage library/MCP integrations separately. Patchcov configuration lives at.patchcov/config.yaml, and markers usepatchcov: coverage.Delete directly as recommended by the issue; no deprecation stub. This requires the next pre-1.0 minor release; version changes and publication are outside this PR.
Deployment Notes
The coverage workflow installs patchcov independently of omni-dev releases. No deployment action required beyond merging this PR through the normal process.
Additional Notes
One committed-diff review found no actionable findings; none fixed or skipped. No implementation-plan departures. The corpus fixture adjustment was incorporated into the plan. Historical ADR-0046/0047 examples and archived commit subjects remain as historical data.
Hosted coverage and cross-platform results remain pending CI. Rustdoc warnings and the existing yanked dependency warning are unrelated follow-ups, outside this removal. The final test build also emits a linker warning that its
__eh_frameexceeds the 16 MiB compact-unwind limit; tests still pass.