Fix/filter max depth - #26
Merged
Merged
Conversation
…f-service) Parsing a BER object using `Filter::from_ber` is recursive, and can cause a stack overflow if parsing crafted data, causing a crash of the application Since the `from_ber` function is defined by a Trait and does not allow extra arguments, we change the following: - `from_ber` now call wrapped functions using a maximum depth - `from_ber` use a default compile-time value of 32 Reported-by: Nozomi Networks Labs via Suricata Team Credit: Nozomi Networks Labs Credit: Trail of Bits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a maximum recursion depth when parsing Filter (potential Denial-of-service)
Parsing a BER object using
Filter::from_beris recursive, and can cause astack overflow if parsing crafted data, causing a crash of the application
Since the
from_berfunction is defined by a Trait and does not allow extraarguments, we change the following:
from_bernow call wrapped functions using a maximum depthfrom_beruse a default compile-time value of 32