Skip to content

0.15.4 prep: linux arm64 packaging, rustls 0.23.45 - #682

Merged
cpu merged 4 commits into
mainfrom
0.15.4-prep
Sep 25, 2026
Merged

cpu merged 4 commits into
mainfrom
0.15.4-prep

Conversation

@cpu

@cpu cpu commented Sep 25, 2026

Copy link
Copy Markdown
Member

@cpu cpu self-assigned this Sep 25, 2026
Comment thread librustls/src/rustls.h
#define RUSTLS_VERSION_NUMBER ((RUSTLS_VERSION_MAJOR << 24) \
|(RUSTLS_VERSION_MINOR << 16) \
|(RUSTLS_VERSION_MINOR << 8))
|(RUSTLS_VERSION_PATCH << 8))

@cpu cpu Sep 25, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is also a small bugfix (in cbindgen.toml), we were shifting in _MINOR twice before 😮‍💨

@djc

djc commented Sep 25, 2026

Copy link
Copy Markdown
Member

Why 22.04 for ARM?

@cpu

cpu commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

Why 22.04 for ARM?

Matching the other pre-existing artifact production jobs where we've avoided using the -latest that shifts unpredictably:

name: Windows (x86_64 MSVC)
runs-on: windows-2022 # x86_64

name: Linux (x86_64 GNU)
runs-on: ubuntu-22.04 # x86_64.

name: Linux (x86-64 GNU Deb)
runs-on: ubuntu-22.04 # x86_64.

name: MacOS (Arm64 and x86_64)
runs-on: macos-14 # arm64.

@djc djc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough!

Was asking because some of the artifact builds do also just use -latest.

@cpu

cpu commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

Was asking because some of the artifact builds do also just use -latest.

It's a fair question. I think only the ones that test the artifacts produced by the earlier stages use -latest. I can't remember why I thought that was helpful, but it seemed like a good idea at the time 😆

@cpu
cpu merged commit d64259f into main Sep 25, 2026
64 checks passed
@cpu
cpu deleted the 0.15.4-prep branch September 25, 2026 17:56
@cpu

cpu commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

vszakats pushed a commit to curl/curl that referenced this pull request Sep 25, 2026
vszakats added a commit to curl/curl that referenced this pull request Sep 25, 2026
Reduces runtime for test steps in two jobs from 15-16 minutes to 6-7.

Rustls-arm64-binaries-thanks-to: Daniel McCarney
Ref: rustls/rustls-ffi#682
Ref: #23065 (comment)
Follow-up to aff6f93 #23065

Closes #23079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants