0.15.4 prep: linux arm64 packaging, rustls 0.23.45 - #682
Conversation
| #define RUSTLS_VERSION_NUMBER ((RUSTLS_VERSION_MAJOR << 24) \ | ||
| |(RUSTLS_VERSION_MINOR << 16) \ | ||
| |(RUSTLS_VERSION_MINOR << 8)) | ||
| |(RUSTLS_VERSION_PATCH << 8)) |
There was a problem hiding this comment.
Note: this is also a small bugfix (in cbindgen.toml), we were shifting in _MINOR twice before 😮💨
|
Why 22.04 for ARM? |
Matching the other pre-existing artifact production jobs where we've avoided using the rustls-ffi/.github/workflows/artifacts.yaml Lines 16 to 17 in 60d5127 rustls-ffi/.github/workflows/artifacts.yaml Lines 50 to 51 in 60d5127 rustls-ffi/.github/workflows/artifacts.yaml Lines 81 to 82 in 60d5127 rustls-ffi/.github/workflows/artifacts.yaml Lines 116 to 117 in 60d5127 |
djc
left a comment
There was a problem hiding this comment.
Fair enough!
Was asking because some of the artifact builds do also just use -latest.
It's a fair question. I think only the ones that test the artifacts produced by the earlier stages use |
|
With arm64 binaries. Thanks-to: Daniel McCarney Ref: rustls/rustls-ffi#682 Ref: #23065 (comment) Ref: #23079 (comment) Closes #23107
Reduces runtime for test steps in two jobs from 15-16 minutes to 6-7. Rustls-arm64-binaries-thanks-to: Daniel McCarney Ref: rustls/rustls-ffi#682 Ref: #23065 (comment) Follow-up to aff6f93 #23065 Closes #23079
curlfor their CI).aws-lc-rsprovider builds.