Conversation
sviyh
force-pushed
the
fix/vehicle-framework-audit
branch
from
September 14, 2026 17:13
213de88 to
ec2577c
Compare
sviyh
force-pushed
the
fix/vehicle-framework-audit
branch
from
September 14, 2026 17:20
ec2577c to
0d9dfe7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes Vehicle Framework compatibility for Vanilla Vehicles Expanded using named VF and Multiplayer actions, shared caravan sessions, and stable vehicle/role references. Synchronizes seats, routes, departure, cargo, passengers, turrets, fuel and flight, and keeps VF path/region work and exit-cell selection deterministic.
Includes the fixes found during VVE QA: restore cargo-tab serialization, buffer fuel-slider changes, resolve role-held pawns for seat assignment and dragging, synchronize turret-target clearing, clear stale flight targeters on world reload, and register the actual abandon action instead of the other-colonist eligibility predicate. The last correction removes the false multiplayer “last colonist” rejection; it does not resolve VF's separate airborne banishment defects.
Both Release projects build without warnings or errors. Retained released-build host/client QA covers caravan departure/return, seats and routes, cargo, fuel, turrets, flight/landing and reconnects, with semantic state checks and delayed desync checks. The released-build matrix is 24 passed, six partial/blocked and one not applicable. Focused A3 follow-up used a development VF build: confirmation/cancel and genuine solo-colonist protection passed in SP/MP; cargo discard and MP arrival remained synchronized.
Remaining framework dependencies: airborne banishment cannot resolve seated pawns in MP and leaves banished pawns aboard in SP; force departure and in-flight cargo require the fixes in SmashPhil/Vehicle-Framework#364 and SmashPhil/Vehicle-Framework#365 to ship and be qualified on released builds; stash recovery seating and empty-ammo reload paths also await released VF fixes. The alternate autoload dialog is feature-disabled. This is not an all-green release sign-off.
Closes #561. Related overlapping work: #592 and #620.