Repository navigation
fix: give the traffic list and detail the flexible row again - #12
Merged
Merged
Conversation
#11 removed the order warning's slot, the first child of `.ml-traffic`, but the grid kept three rows (`auto auto 1fr`). The split with the list and the detail moved into the second, auto row. There the list (`flex: 1 1 0`) and the detail have no height, so in Necto the Traffic tab showed only the toolbar and the live strip, at any window size. jsdom does no layout, so the tests passed. The grid now has one row per child, and a test pins the row count to what render() draws. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ryan-son
added a commit
that referenced
this pull request
Oct 26, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression from #11: in Necto, the Traffic tab showed no requests and no detail.
#11 removed the registration order warning. Its slot, an always-present
div.ml-order-warning, was the first child of.ml-traffic, and the grid still declared three rows (auto auto 1fr). With two children, the split holding the list and the detail moved into the second,autorow. There the list (flex: 1 1 0) and the detail have no height, so only the toolbar and the live strip were drawn, at any window size. jsdom does no layout, so every test passed.style.css:.ml-trafficisgrid-template-rows: auto 1fr.render()draws, and checks that the split gets the last1frrow.Found while filling the 0.2.0 verification rows in #8. Not released: 0.2.0 isn't tagged yet.
Changelog
None. The regression was never released.
Agent interface
No change. Panel layout only; no operation, input, output or
maplocal.statefield changes.Test Plan
cd Panel && npx tsc --noEmit: OK.npx vitest run: 1101 passed (1100 plus the new test).script/build-panelregeneratedEmbeddedPanel.swift.GET /json(mocked, 201) andGET /uuid(passthrough, 200)./jsonopens the detail with the mocked body{"mocked":"b"}from Necto's network records.