Repository navigation
Conversation
|
PR author is not in the allowed authors list. |
shikhar
deleted the
detail/dead-code/chore-types-remove-unused-fromstr-and-intoiterator-e48072
branch
September 30, 2026 17:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the "dead-on-arrival" trait impls from src/types.rs:
"impl FromStr for ObjectKind", "impl FromStr for ObjectKey",
and "impl IntoIterator for BucketNameSet". None of these had any
callers in the codebase (production or test) — confirmed via grep
for '.parse()', 'from_str', 'IntoIterator', and 'into_iter' across
src/, tests/, and the binary — and the 'use std::str::FromStr'
import that existed only to support the two FromStr impls is
retired in the same change.
"ObjectKind" and "ObjectKey" still expose Deserialize for
deserialization (used by axum's Path<(ObjectKind, ObjectKey)>
extractor in routes.rs), and "BucketNameSet" still exposes
Deref<Target = [BucketName]> and From for iteration
and construction, so removing these impls does not change any
runtime behavior or output.
History
Dead Code PRs can be configured here.