Skip to content

chore(types): remove unused FromStr and IntoIterator impls - #157

Merged
shikhar merged 1 commit into
mainfrom
detail/dead-code/chore-types-remove-unused-fromstr-and-intoiterator-e48072
Sep 30, 2026
Merged

shikhar merged 1 commit into
mainfrom
detail/dead-code/chore-types-remove-unused-fromstr-and-intoiterator-e48072

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Remove the "dead-on-arrival" trait impls from src/types.rs:
"impl FromStr for ObjectKind", "impl FromStr for ObjectKey",
and "impl IntoIterator for BucketNameSet". None of these had any
callers in the codebase (production or test) — confirmed via grep
for '.parse()', 'from_str', 'IntoIterator', and 'into_iter' across
src/, tests/, and the binary — and the 'use std::str::FromStr'
import that existed only to support the two FromStr impls is
retired in the same change.

"ObjectKind" and "ObjectKey" still expose Deserialize for
deserialization (used by axum's Path<(ObjectKind, ObjectKey)>
extractor in routes.rs), and "BucketNameSet" still exposes
Deref<Target = [BucketName]> and From for iteration
and construction, so removing these impls does not change any
runtime behavior or output.

History

  • Last materially changed September 2025 (@shikhar) — introduced in commit 2c1010e (init); never touched since.

Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from shikhar September 30, 2026 17:51
@greptile-apps

greptile-apps Bot commented Sep 30, 2026

Copy link
Copy Markdown

PR author is not in the allowed authors list.

@shikhar
shikhar merged commit ea56953 into main Sep 30, 2026
7 checks passed
@shikhar
shikhar deleted the detail/dead-code/chore-types-remove-unused-fromstr-and-intoiterator-e48072 branch September 30, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant