PLASMA-8275: add custom quarterNames in Calendar-like - #3198
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (65)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughCalendar, DatePicker, DatePickerRange, and DateTimePicker now accept custom names for the four quarters. The change passes those names to quarter views and date-info logic, retains default names when entries are absent, and adds tests and documentation. ChangesCustom quarter labels in Calendar
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant Caller
participant DatePicker
participant useDatePicker
participant Calendar
Caller->>DatePicker: quarterNames prop
DatePicker->>useDatePicker: quarterNames option
DatePicker->>Calendar: quarterNames prop
Calendar-->>Caller: quarter labels in calendar view
useDatePicker-->>Caller: quarter name in date info
Merge Risk: ⚪ Minimal · up to Custom quarter labels appear ready to merge after normal checks; no actionable merge-blocking issue is established. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to Custom labels change what applications display and receive in date callbacks. The inspected components retain their date-selection checks, and no new privileged operation was identified. Risk remains low rather than minimal because downstream applications may handle callback labels in ways that could not be assessed here. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-3198/ |
Contributor
|
Ок |
TitanKuzmich
force-pushed
the
PLASMA-8275
branch
from
September 28, 2026 07:24
9249636 to
8c4f82f
Compare
TitanKuzmich
marked this pull request as ready for review
September 28, 2026 07:25
TitanKuzmich
requested review from
Yakutoc,
Yeti-or,
neretin-trike and
shuga2704
as code owners
September 28, 2026 07:25
TitanKuzmich
requested review from
vmytnik
and removed request for
Yakutoc,
Yeti-or and
neretin-trike
September 28, 2026 07:25
vmytnik
approved these changes
Sep 28, 2026
IgorYar
approved these changes
Sep 28, 2026
shuga2704
approved these changes
Sep 28, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core
Calendar, Datepicker, DateTimePicker
What/why changed
Summary by CodeRabbit
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @salutejs/plasma-asdk@0.396.0-canary.3198.36391526963.0 npm install @salutejs/plasma-b2c@1.638.0-canary.3198.36391526963.0 npm install @salutejs/plasma-colors@0.24.0-canary.3198.36391526963.0 npm install @salutejs/plasma-core@1.245.0-canary.3198.36391526963.0 npm install @salutejs/plasma-giga@0.365.0-canary.3198.36391526963.0 npm install @salutejs/plasma-homeds@0.365.0-canary.3198.36391526963.0 npm install @salutejs/plasma-hope@1.392.0-canary.3198.36391526963.0 npm install @salutejs/plasma-icons@1.251.0-canary.3198.36391526963.0 npm install @salutejs/plasma-new-hope@0.382.0-canary.3198.36391526963.0 npm install @salutejs/plasma-tokens@1.156.0-canary.3198.36391526963.0 npm install @salutejs/plasma-tokens-b2b@1.67.0-canary.3198.36391526963.0 npm install @salutejs/plasma-tokens-b2c@0.78.0-canary.3198.36391526963.0 npm install @salutejs/plasma-tokens-core@0.15.0-canary.3198.36391526963.0 npm install @salutejs/plasma-tokens-web@1.82.0-canary.3198.36391526963.0 npm install @salutejs/plasma-typo@0.55.0-canary.3198.36391526963.0 npm install @salutejs/plasma-web@1.640.0-canary.3198.36391526963.0 npm install @salutejs/sdds-bizcom@0.370.0-canary.3198.36391526963.0 npm install @salutejs/sdds-cs@0.374.0-canary.3198.36391526963.0 npm install @salutejs/sdds-dfa@0.368.0-canary.3198.36391526963.0 npm install @salutejs/sdds-finai@0.361.0-canary.3198.36391526963.0 npm install @salutejs/sdds-icons@0.9.0-canary.3198.36391526963.0 npm install @salutejs/sdds-insol@0.365.0-canary.3198.36391526963.0 npm install @salutejs/sdds-insol-next@0.364.0-canary.3198.36391526963.0 npm install @salutejs/sdds-netology@0.369.0-canary.3198.36391526963.0 npm install @salutejs/sdds-os@0.40.0-canary.3198.36391526963.0 npm install @salutejs/sdds-platform-ai@0.369.0-canary.3198.36391526963.0 npm install @salutejs/sdds-sbcom@0.370.0-canary.3198.36391526963.0 npm install @salutejs/sdds-scan@0.368.0-canary.3198.36391526963.0 npm install @salutejs/sdds-serv@0.369.0-canary.3198.36391526963.0 npm install @salutejs/sdds-vc@0.4.0-canary.3198.36391526963.0 npm install @salutejs/core-themes@0.43.0-canary.3198.36391526963.0 npm install @salutejs/plasma-themes@0.65.0-canary.3198.36391526963.0 npm install @salutejs/sdds-themes@0.83.0-canary.3198.36391526963.0 npm install @salutejs/sdds-api-tests@0.27.0-canary.3198.36391526963.0 npm install @salutejs/plasma-cy-utils@0.175.0-canary.3198.36391526963.0 npm install @salutejs/plasma-sb-utils@0.246.0-canary.3198.36391526963.0 npm install @salutejs/plasma-tokens-utils@0.63.0-canary.3198.36391526963.0 # or yarn add @salutejs/plasma-asdk@0.396.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-b2c@1.638.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-colors@0.24.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-core@1.245.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-giga@0.365.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-homeds@0.365.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-hope@1.392.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-icons@1.251.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-new-hope@0.382.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-tokens@1.156.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-tokens-b2b@1.67.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-tokens-b2c@0.78.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-tokens-core@0.15.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-tokens-web@1.82.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-typo@0.55.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-web@1.640.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-bizcom@0.370.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-cs@0.374.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-dfa@0.368.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-finai@0.361.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-icons@0.9.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-insol@0.365.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-insol-next@0.364.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-netology@0.369.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-os@0.40.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-platform-ai@0.369.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-sbcom@0.370.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-scan@0.368.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-serv@0.369.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-vc@0.4.0-canary.3198.36391526963.0 yarn add @salutejs/core-themes@0.43.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-themes@0.65.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-themes@0.83.0-canary.3198.36391526963.0 yarn add @salutejs/sdds-api-tests@0.27.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-cy-utils@0.175.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-sb-utils@0.246.0-canary.3198.36391526963.0 yarn add @salutejs/plasma-tokens-utils@0.63.0-canary.3198.36391526963.0