Skip to content

feat(notifications): polish popup layout and motion - #17

Merged
sandeepbist merged 1 commit into
mainfrom
feat/notification-polish
Oct 28, 2026
Merged

sandeepbist merged 1 commit into
mainfrom
feat/notification-polish

Conversation

@sandeepbist

Copy link
Copy Markdown
Owner

Why

Notification popups reserve a wide icon column and use prominent action surfaces. Use a compact app header and full-width message text with restrained motion.

What changed

  • Keep a small app icon, app name, one dismiss target, and quieter wrapped action buttons.
  • Use a gentle 6-pixel fade and slide. Honor reduced motion and keep overflowing actions reachable by keyboard and scrolling.
  • Transfer hover pause when a replacement popup appears beneath a stationary pointer.

Scope

  • Notification popup presentation and its shared card behavior checks.
  • History expansion, message preview settings, sender actions, delivery, and expiry remain available.
  • No notification service, settings, polling, or model-retention changes.

Blast Radius

The card also renders notification history. Production Qt checks cover its collapsed and expanded text, timestamps, actions, and dismissal. Popup swaps preserve records and synchronize their hover state.

Verification

  • Production Qt checks passed for dark and light themes, narrow and busy action layouts, keyboard interaction, history, expiry, interrupted swaps, and reduced motion.
  • Isolated D-Bus delivery, sender actions, expiry, DND, history retention, and burst checks passed. Inactive content and production QML/Wayland validation passed.
  • Independent review found no confirmed blocker. Eight additional rapid-cancellation probes preserved hover pause. Native simple and action previews were inspected, then the normal shell was activated with unchanged preferences and warm voice ready. Rare timer ordering is not exhaustively tested.

@sandeepbist

Copy link
Copy Markdown
Owner Author

Automated verification by gpt-6-luna (max reasoning). Verdict: PASS+NOTES.

Source behavior: PASS for head d0ca030 on base cdc6e78 (feat/control-center-refresh), stable patch-id 987a6b5ea4351e39a078f597808ca80e2b4b94ba.
The production Qt fixture exited 0 with dark 350px, light 220px, and motion cases. The parent probe through tests/qml.py exited 0. It confirmed primary and secondary click routing and Space activation, and measured the parent 220px popup at a 38px icon with summary x=64 and width=118. Parent replacement did not transfer stationary-pointer hover to the new popup.

GitHub readiness: OPEN; MERGEABLE; CLEAN. 5 displayed checks succeeded, all completed October 18. Reviews: 0; unresolved review threads: 0; auto-merge: none. Review decision is empty; approval rules were not checked.
The fixture ran offscreen in preview mode with temporary state, cache, and runtime paths. Display and D-Bus environment variables were unset. The full project suite was not run.
No head or base drift at posting time.

@sandeepbist
sandeepbist force-pushed the feat/control-center-refresh branch from cdc6e78 to 8c08934 Compare October 28, 2026 19:33
Base automatically changed from feat/control-center-refresh to main October 28, 2026 19:41
@sandeepbist
sandeepbist force-pushed the feat/notification-polish branch from d0ca030 to de932c9 Compare October 28, 2026 19:44
@sandeepbist
sandeepbist merged commit 09d8ead into main Oct 28, 2026
5 checks passed
@sandeepbist
sandeepbist deleted the feat/notification-polish branch October 28, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant