Skip to content

[codex] Make Notes keyboard fixture independent of retained selection - #21

Merged
sandeepbist merged 1 commit into
mainfrom
fix/notes-popup-keyboard-fixture
Oct 28, 2026
Merged

sandeepbist merged 1 commit into
mainfrom
fix/notes-popup-keyboard-fixture

Conversation

@sandeepbist

Copy link
Copy Markdown
Owner

The Notes popup fixture assumed one Down key would select Pin note. A reopened Qt menu can retain a highlighted row, so the test can activate Move to Trash and fail with Keyboard pin ignored. Navigate to Pin note with native arrow keys before pressing Return. Keep the assertion that the note becomes pinned.

Native checks pass with no initial selection and with the Archive row selected. The original sequence fails the retained-selection case. Replacing Return with Escape still fails the pin assertion. Application source is unchanged.

This inherited fixture issue was exposed while investigating #15. The exact selection in the old hosted failure was not logged. This PR is independent of the island feature stack.

@sandeepbist

Copy link
Copy Markdown
Owner Author

Automated verification by Codex (gpt-6-luna). Verdict: PASS+NOTES.

Verified head 1b44549 against main base d990494; stable patch-id 81e7ba7ad62a3f1acaf16c48de86e45582993a40. Unmodified tests/notes-popup.py passes. Native Qt controls pass with menu currentIndex -1 and 1. The original sequence fails at seeded index 1 with Keyboard pin ignored, and replacing Return with Escape fails the same pinned-state assertion. The new fixture checks that Pin note is highlighted before activation. Application source is unchanged; changed-comment count is 0.

Limits: tests ran offscreen, so they did not check live compositor input. The historical hosted failure log does not record its selected index; this run does not infer it. All GitHub checks pass, but review decision remains REVIEW_REQUIRED with zero unresolved threads. Main-target owner approval remains a separate gate. This comment is automated verification, not human approval.

@sandeepbist
sandeepbist merged commit 6452843 into main Oct 28, 2026
5 checks passed
@sandeepbist
sandeepbist deleted the fix/notes-popup-keyboard-fixture branch October 28, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant