Repository navigation
fix(launcher): detach application output from launcher replies - #22
Conversation
|
Automated independent verification: PASS This is verification evidence, not a formal approval. Verified exact head
The installed Gio binding accepts the native call. Upstream GLib 2.90.1 shows both APIs use the same desktop-entry launch dispatcher and SEARCH_PATH defaults; the change supplies explicit child stream descriptors. No unintended desktop-entry semantic change was found. D-Bus activation intentionally ignores spawn descriptors, as documented by Gio. Changed-comment review found one added external stream-behavior explanation to keep, no deletion recommendations, no MUST KILL or HOLD flags. Actual deletions 0. The single GitHub snapshot showed 5/5 checks successful, REVIEW_REQUIRED, no reviews or review threads, and merge state BLOCKED. That readiness state is separate from this source PASS. No CI polling, formal approval, merge, watch or compositor/plugin changes occurred. Scope limits include the installed GLib/Python/Quickshell versions, offscreen UI and synthetic launch fixtures. D-Bus service auto-start and real terminal PTYs were not exercised. |
3b4e593 to
1e5c492
Compare
Why
Applications inherited the launcher's reply pipes. A long-running application could keep the JSON response open and leave the launcher waiting.
What changed
Scope
Blast Radius
The change affects application launches through the existing helper. It keeps the native desktop-entry API and does not alter application closing.
Verification
python3 tests/launcher.pypasses for GUI and terminal entries, quoted arguments, field codes, working directories, environment cleanup, and missing entries.