Skip to content

fix(gtk): align Thunar layout and palette contrast - #23

Merged
sandeepbist merged 1 commit into
mainfrom
codex/thunar-layout
Oct 28, 2026
Merged

sandeepbist merged 1 commit into
mainfrom
codex/thunar-layout

Conversation

@sandeepbist

Copy link
Copy Markdown
Owner

Why

Thunar's bundled styling used large insets, delayed fades, and inconsistent spacing. This update makes the sidebar, toolbar, file view, and status bar more compact and keeps selection contrast tied to the current palette.

What changed

  • Refine Thunar spacing, selection colors, toolbar controls, and focused location entries.
  • Migrate two additional unchanged bundled stylesheet revisions while preserving user-edited files and symlinks.
  • Extend the existing GTK checks across all four migration fixtures.

Scope

  • Covers the bundled Thunar stylesheet and its existing migration path.
  • Does not change unrelated GTK application layouts or replace custom stylesheets.

Blast Radius

Users of the bundled stylesheet receive the revised Thunar layout. Migration is limited to exact known file hashes, so custom CSS remains intact.

Verification

  • python3 tests/gtk-theme.py --live passes dark and light palettes, named and wallpaper colors, all four migration revisions, native selection states, sidebar contrast, and user-file preservation.

@sandeepbist

Copy link
Copy Markdown
Owner Author

Automated independent verification. PASS+NOTES. This is a verification comment, not a formal approval.

The review verifies Thunar layout and palette behavior while preserving custom CSS. It covers exactly head 2f5a9487b71df1c41a8038d325f352a4d6d65be5, base main d9904944e943d33c14fbbfb2976867b03ca67d8c, and stable patch-id e8384c19ca9ecc7a9acfb3fb271249c5efc064df.

  • The existing GTK driver passes on both parent and head, with and without --live. Native DISPLAY :0 and GTK 3.24.52 were available. No window was shown and no desktop setting was changed.
  • Head verification covers dark/light, named/wallpaper palettes, and all four legacy/solid/inset/pass1 fixtures. It verifies both GTK config directories, real Matugen generation, native GTK3 selected/focused/backdrop states, named selection colors, sidebar surfaces, and opaque selection text. Independent style probes measured minimum contrast of 10.30:1 for file selections and 5.16:1 for sidebar selections in these profiles. Native queries also confirm zero frame margins, 4px padding, no frame border, full opacity, and the new location entry metrics.
  • Both migration implementations pass an additional 40-case matrix each. Exact allowed fixtures migrate with original backups. Custom CSS, known fixture bytes behind symlinks, dangling symlinks, comment edits, and extra newlines remain intact. A parent-versus-head negative control fails on the parent's 10px/15px frame margins, as expected.
  • Changed-comment review recommends deleting only the redundant three-line Toolbar banner at setup/config/gtk-3.0/thunar.css:141. This is optional cleanup. Actual deletions by this review are zero. All 25 comment blocks in the two new historical fixtures must remain byte-exact. Their SHA256 values match the migration allowlist, and removing a comment prevents migration in the probe. The inset fixture is also byte-identical to the pinned parent stylesheet.

No source correctness findings were reproduced. One initial probe miscomputed a transparent parent background. The failed probe and logs are preserved, and the corrected probe passes. This review does not establish broad visual polish, actual Thunar/Exo rendering, or GTK4 runtime behavior. Both GTK config copies were parsed and resolved using GTK3.

GitHub readiness is separate. The single metadata snapshot matched the pinned head/base and reported BLOCKED, REVIEW_REQUIRED, zero reviews, zero review threads, and a failed Offline checks on Arch check. Quick checks and the three CodeQL contexts passed. No CI polling occurred. A separate failed-job log request hit gh's terminal-escape output guard, so the CI failure cause remains unclassified.

Evidence is retained locally in /home/Zeref/.local/share/modesty/research/shipping-2026-10-28/extra/gtk/review/report.md, verdict.json, commands.json, source manifests, coverage data, and complete probe logs. Isolated runtime probes remain in /home/Zeref/.t3/worktrees/Modesty/t3-f571f9e4/.gtk-review-probes-2f5a9487-ncdlnv9l. The supplied worktree's tracked files and HEAD are unchanged. No production edits, commits, pushes, approvals, merges, watches, compositor changes, or nested agents were used.

@sandeepbist
sandeepbist merged commit a122477 into main Oct 28, 2026
5 checks passed
@sandeepbist
sandeepbist deleted the codex/thunar-layout branch October 28, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant