Repository navigation
feat(luma): add opt-in private desktop capture - #24
Conversation
|
Automated independent verification for PR #24. This is a source verdict, not a GitHub approval. Source verdict: FAIL. Reviewed all 16 changed paths and changed comments at head P2: failed unload loses recovery information. In Fresh verification passed the 75-check loader suite, production settings and preview checks, six ASan/UBSan callback cases, protocol-client build, a focused locked-state check with zero backend calls, and a fresh plugin compilation. The binary SHA-256 exactly matches the retained nested-run binary: The structure correction is valid. The capture fixture is independently copied to I inspected retained exact-hash native evidence rather than rerunning the full integration suite. Independent checks verified source/binary hashes, 35 complete expected-image comparisons, and 19 freshly decoded video frames with both background phases. Representative local and exported production frames show the canvas locally and its omission from capture. No parent-compositor mutation or recipient-app test occurred. This does not certify arbitrary compositor/plugin combinations, portals, Google Meet, or Discord. The feature remains experimental and scoped to Hyprland Changed-comment review found six justified keeps and 18 prose-line deletion recommendations across five files. The keeps are proven upstream fadeout and hook constraints, Lua byte-escape behavior, and three actual public CLI help docstrings. File specimens and interpreter directives were treated as functional data. These style notes are separate from the recovery defect; no source edits were made. At the single entry snapshot, Quick checks and three CodeQL check entries had succeeded; Offline checks on Arch was still running. There were no reviews or review threads. GitHub reported |
|
Automated independent verification by Codex/gpt-6.1-sol. This is a normal verification comment, not a formal GitHub approval. I did not author this change. Source verdict: PASS+NOTES. This covers all 16 paths at head The real production helper now unloads before marker deletion and reloads configuration even without a marker. My isolated regression runs the actual old and final helper CLI with temporary files and mocked IPC. The old helper fails the intended Fresh affected checks pass: the loader suite reports 100 checks with real Lua parsing/runtime; production Settings and preview checks pass; six callback cases pass under ASan/UBSan; structure resolves 145 QML files and literal imports; helper help and patch whitespace checks pass. Comment cleanup removes 12 narration lines and three unused docstrings. Public CLI help, directives, specimens, and evidenced external constraints remain. Keeping the generated Lua provenance and persisted registration suffix avoids an unrelated migration. The tested I inspected the parent's fresh successful nested CI readiness: FAILED at the single snapshot. Quick checks and three CodeQL entries passed. Offline checks on Arch failed. Its log reports Formal approval: REQUIRED. GitHub reports |
3bd592d to
f9a879e
Compare
Why
Native capture exclusion can black out a shared monitor instead of showing the desktop behind Luma. This experimental opt-in plugin renders a separate capture scene without Luma or the island while local interaction continues.
What changed
Scope
Tradeoffs
The plugin uses internal compositor hooks. A compositor update disables compatibility until the implementation is checked against that build.
Blast Radius
Only enabled, supported capture sessions use the plugin. Rendering or compatibility failures refuse capture instead of falling back to an unfiltered frame. Compositor hooks can still crash the desktop if their assumptions are wrong.
Verification