Skip to content

Repository navigation

⚡ Refactor Canvas Crawler fetches to run concurrently #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

⚡ Refactor Canvas Crawler fetches to run concurrently #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 26 additions & 21 deletions extension/background/canvas-crawler.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,31 +20,36 @@ async function crawlCanvasCourse(origin, courseId, fetchImpl = fetch) {

// 1. Fetch Course details & syllabus
const courseUrl = `${origin}/api/v1/courses/${courseId}?include[]=syllabus_body`;
const courseRes = await fetchImpl(courseUrl, { credentials: 'include' });
if (!courseRes.ok) {
throw new Error(`Failed to fetch Canvas course info (${courseRes.status})`);
}
const courseJson = await courseRes.json();
const coursePromise = fetchImpl(courseUrl, { credentials: 'include' }).then(async (res) => {
if (!res.ok) {
throw new Error(`Failed to fetch Canvas course info (${res.status})`);
}
return res.json();
});

// 2. Fetch Assignments list (up to 50)
const assignmentsUrl = `${origin}/api/v1/courses/${courseId}/assignments?per_page=50`;
let assignments = [];
try {
const assignRes = await fetchImpl(assignmentsUrl, { credentials: 'include' });
if (assignRes.ok) {
const assignJson = await assignRes.json();
if (Array.isArray(assignJson)) {
assignments = assignJson.map((a) => ({
title: a.name || 'Untitled Assignment',
description: stripHtml(a.description || '').slice(0, 1000),
points: a.points_possible || 0,
dueAt: a.due_at || null
}));
const assignmentsPromise = fetchImpl(assignmentsUrl, { credentials: 'include' })
.then(async (res) => {
if (res.ok) {
const assignJson = await res.json();
if (Array.isArray(assignJson)) {
return assignJson.map((a) => ({
title: a.name || 'Untitled Assignment',
description: stripHtml(a.description || '').slice(0, 1000),
points: a.points_possible || 0,
dueAt: a.due_at || null
}));
}
}
}
} catch (e) {
console.warn('Could not fetch assignments list:', e);
}
return [];
})
.catch((e) => {
console.warn('Could not fetch assignments list:', e);
return [];
});

const [courseJson, assignments] = await Promise.all([coursePromise, assignmentsPromise]);

return {
title: courseJson.name || courseJson.course_code || 'Canvas Course',
Expand Down
47 changes: 26 additions & 21 deletions extension/background/canvas-crawler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,31 +20,36 @@ export async function crawlCanvasCourse(origin, courseId, fetchImpl = fetch) {

// 1. Fetch Course details & syllabus
const courseUrl = `${origin}/api/v1/courses/${courseId}?include[]=syllabus_body`;
const courseRes = await fetchImpl(courseUrl, { credentials: 'include' });
if (!courseRes.ok) {
throw new Error(`Failed to fetch Canvas course info (${courseRes.status})`);
}
const courseJson = await courseRes.json();
const coursePromise = fetchImpl(courseUrl, { credentials: 'include' }).then(async (res) => {
if (!res.ok) {
throw new Error(`Failed to fetch Canvas course info (${res.status})`);
}
return res.json();
});

// 2. Fetch Assignments list (up to 50)
const assignmentsUrl = `${origin}/api/v1/courses/${courseId}/assignments?per_page=50`;
let assignments = [];
try {
const assignRes = await fetchImpl(assignmentsUrl, { credentials: 'include' });
if (assignRes.ok) {
const assignJson = await assignRes.json();
if (Array.isArray(assignJson)) {
assignments = assignJson.map((a) => ({
title: a.name || 'Untitled Assignment',
description: stripHtml(a.description || '').slice(0, 1000),
points: a.points_possible || 0,
dueAt: a.due_at || null
}));
const assignmentsPromise = fetchImpl(assignmentsUrl, { credentials: 'include' })
.then(async (res) => {
if (res.ok) {
const assignJson = await res.json();
if (Array.isArray(assignJson)) {
return assignJson.map((a) => ({
title: a.name || 'Untitled Assignment',
description: stripHtml(a.description || '').slice(0, 1000),
points: a.points_possible || 0,
dueAt: a.due_at || null
}));
}
}
}
} catch (e) {
console.warn('Could not fetch assignments list:', e);
}
return [];
})
.catch((e) => {
console.warn('Could not fetch assignments list:', e);
return [];
});

const [courseJson, assignments] = await Promise.all([coursePromise, assignmentsPromise]);

return {
title: courseJson.name || courseJson.course_code || 'Canvas Course',
Expand Down
Loading